Bug 52262 - KPixmapIO doesn't work with remote displays
Summary: KPixmapIO doesn't work with remote displays
Status: RESOLVED FIXED
Alias: None
Product: kdelibs
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Stephan Kulow
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-12-24 21:19 UTC by Patrick Julien
Modified: 2003-03-10 21:43 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
Fix (1.69 KB, patch)
2003-02-28 20:02 UTC, Stephan Kulow
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Julien 2002-12-24 21:19:25 UTC
Version:            (using KDE Devel)
Installed from:    Compiled sources
Compiler:          gcc 3.2 
OS:          Linux

KPixmapIO still tries to use XShmPutImage when running on a remote display.
Comment 1 Stephan Kulow 2003-02-28 20:02:30 UTC
Created attachment 1076 [details]
Fix
Comment 2 Stephan Kulow 2003-02-28 20:02:51 UTC
The attached patch tries to fix that. Please test and review. 
Comment 3 Patrick Julien 2003-03-03 02:33:40 UTC
Subject: Re:  KPixmapIO doesn't work with remote displays

well, after testing it, it seems to be working fine.

However, it is considerably slower than I expected.  I would like to suggest 
the removal of XSync and the one after the XSmAttach and the call to XSync 
that was there previously.

It seems that gdk_draw_rgb_image_dithalign() is considerably faster than 
KPixmap IO for equivalent work.  However, gtk seems to fall back to using 
XPutImage instead of using a completely different code path.

Or, perhaps, I'm not using the correct facility.  Is there something else I 
should be using than KPixmapIO?

Comment 4 Stephan Kulow 2003-03-03 15:02:36 UTC
Subject: Re:  KPixmapIO doesn't work with remote displays

Am Monday 03 March 2003 02:33 schrieben Sie:
> ------- You are receiving this mail because: -------
> You are the assignee for the bug, or are watching the assignee.
>      
> http://bugs.kde.org/show_bug.cgi?id=52262     
> 
> 
> 
> 
> ------- Additional Comments From freak@codepimps.org  2003-03-03 02:33 -------
> Subject: Re:  KPixmapIO doesn't work with remote displays
> 
> well, after testing it, it seems to be working fine.
> 
> However, it is considerably slower than I expected.  I would like to suggest 
> the removal of XSync and the one after the XSmAttach and the call to XSync 
> that was there previously.
> 
> It seems that gdk_draw_rgb_image_dithalign() is considerably faster than 
> KPixmap IO for equivalent work.  However, gtk seems to fall back to using 
> XPutImage instead of using a completely different code path.
> 
> Or, perhaps, I'm not using the correct facility.  Is there something else I 
> should be using than KPixmapIO?
Hmm, KPixmapIO is for converting images afaik. What are you trying to do?

Greetings, Stephan

Comment 5 Patrick Julien 2003-03-03 15:05:18 UTC
Subject: Re:  KPixmapIO doesn't work with remote displays

> Hmm, KPixmapIO is for converting images afaik. What are you trying to do?

converting images, but as fast as I can without stepping out of KDE/qt.  Look 
in koffice/krita/core/strategy/kis_strategy_colorspace_rgb.cc.


Comment 6 Stephan Kulow 2003-03-10 21:43:15 UTC
I made the XSync call so it only does it when called first. I guess that's 
a good enough compromise. If you have general speedup patches, let 
me (and Lubos) know. 
Comment 7 Patrick Julien 2003-03-10 21:46:42 UTC
Subject: Re:  KPixmapIO doesn't work with remote displays

On March 10, 2003 03:43 pm, you wrote:
> ------- You are receiving this mail because: -------
> You reported the bug, or are watching the reporter.
>
> http://bugs.kde.org/show_bug.cgi?id=52262
> coolo@kde.org changed:
>
>            What    |Removed                     |Added
> ---------------------------------------------------------------------------
>- Status|NEW                         |RESOLVED
>          Resolution|                            |FIXED
>
>
>
> ------- Additional Comments From coolo@kde.org  2003-03-10 21:43 -------
> I made the XSync call so it only does it when called first. I guess that's
> a good enough compromise. If you have general speedup patches, let
> me (and Lubos) know.

thanks, no problem