Bug 51891 - redmond theme maximized shows top/bottom border
Summary: redmond theme maximized shows top/bottom border
Status: RESOLVED DUPLICATE of bug 56654
Alias: None
Product: kwin
Classification: Plasma
Component: decorations (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-12-14 12:28 UTC by Jarne (kdebug)
Modified: 2003-04-15 21:02 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
Patch that removes borders from maximized windows (616 bytes, patch)
2003-03-08 03:12 UTC, Pavel Roskin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jarne (kdebug) 2002-12-14 12:28:20 UTC
Version:            (using KDE Devel)
Installed from:    Compiled sources
OS:          Linux

When maximized the redmond theme still has the top and bottom resize borders showing.
Comment 1 Pavel Roskin 2003-03-08 02:54:51 UTC
The problem is not specific to the Redmond theme. In fact, I couldn't find any
theme that would draw the border for normal windows, but not for maximized
windows. Laptop and CDE themes show exactly the same behavior.
The code responsible for this behavior seems to be in kdebase/kwin/client.cpp,
function Client::maximize. There is a comment "hide right and left border of
maximized windows". No word about top and bottom borders.
It seems that the generic code (i.e. not specific to any theme) doesn't know the
border width above the title bar. Maybe it should be added to the WindowWrapper
class.
Anyway, here's my patch for the Redmond theme. I have tested it, and it works
just fine for me (KDE 3.1). But I'm not really familiar with KDE code, so please
be careful.




Looking at the code for the Redmond theme
(kdebase/kwin/clients/redmond/redmond.cpp, function GalliumClient::paintEvent),
it appears that the code is not specifically trying to suppress any borders,
vertical or horizontal.
Comment 2 Pavel Roskin 2003-03-08 03:12:49 UTC
Created attachment 1134 [details]
Patch that removes borders from maximized windows

When the window is fully maximized and the maximized windows cannot be moved
(it's an option), grow the client area by 4 bytes in every direction to push
the borders out of the screen. Unlike the common code, I don't care if the
panel is bordering the window on one of the sides. Borders are annoying even
when they touch the panel.
Comment 3 Datschge 2003-04-07 13:12:05 UTC
I think the solution to this bug should be linked to the Control Center > Desktop > 
Window Behavior > Moving > "Allow moving and resizing of maximized windows" 
option. If this option is disabled then there's no reason to show the border since you 
can't resize the window anyway. If this option is enabled however the border should be 
still shown. 
Comment 4 Lubos Lunak 2003-04-15 21:00:36 UTC
The patch is wrong, sorry, you can't just push the borders out of the screen. That's also the 
reason this feature was disabled until it will be implemented properly for KDE3.2. 
 
Comment 5 Lubos Lunak 2003-04-15 21:02:38 UTC

*** This bug has been marked as a duplicate of 56654 ***