Bug 51446 - controlling menus with keyboard doesn't skip disabled items
Summary: controlling menus with keyboard doesn't skip disabled items
Status: RESOLVED FIXED
Alias: None
Product: kdelibs
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Stephan Kulow
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-12-02 22:46 UTC by Jay
Modified: 2003-01-12 17:02 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
Change the keyboard navigation of disabed items style hint (810 bytes, patch)
2002-12-22 19:25 UTC, Maksim Orlovich
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jay 2002-12-02 22:46:40 UTC
Version:           unknown (using KDE 3.0.9)
Compiler:          gcc version 3.2
OS:          Linux (i686) release 2.4.19

header should say it all.. why bother selecting disabled menu items... maybe this behaviour is pure intention, but I assume access to enabled items is faster and easier if disabled items are skipped
Comment 1 Maksim Orlovich 2002-12-06 17:29:03 UTC
I think the idea is that the number of keypresses of down arrow you need doesn't 
change. Since this is kind of a disputable thing, I am changing severity to wishlist, 
until someone with expertise can decide whether more users would prefer it this way  
or the way you describe... That's probably something usability people should look 
at; unfortunately, no usability package, so not reassigned... 
 
 
Comment 2 Stephan Kulow 2002-12-22 19:08:34 UTC
Maksim, can we build that in a GUI style or would all need to follow it? 
I would like to see it for CVS keramik, I can't hardly tell how it would feel ;( 
Comment 3 Maksim Orlovich 2002-12-22 19:25:31 UTC
Created attachment 643 [details]
Change the keyboard navigation of disabed items style hint

The following patch to kdelibs/kdefx/kstyle.cpp makes the change.. Less work to
patch it here than in Keramik (since keramik doesn't re-implement stylehint)
Comment 4 Stephan Kulow 2002-12-22 20:53:55 UTC
Subject: Re:  controlling menus with keyboard doesn't skip disabled items

On Sonntag, 22. Dezember 2002 19:25, you wrote:
> ------- You are receiving this mail because: -------
> You are the assignee for the bug, or are watching the assignee.
>
> http://bugs.kde.org/show_bug.cgi?id=51446
>
>
>
>
> ------- Additional Comments From mo002j@mail.rochester.edu  2002-12-22
> 19:25 ------- Created an attachment (id=643)
>  --> (http://bugs.kde.org/attachment.cgi?id=643&action=view)
> Change the keyboard navigation of disabed items style hint
>
> The following patch to kdelibs/kdefx/kstyle.cpp makes the change.. Less
> work to patch it here than in Keramik (since keramik doesn't re-implement
> stylehint)

Thanks, trying it now

Greetings, Stephan

Comment 5 Stephan Kulow 2002-12-22 20:57:49 UTC
Subject: Re:  controlling menus with keyboard doesn't skip disabled items

On Sonntag, 22. Dezember 2002 19:25, Maksim Orlovich wrote:

>
> The following patch to kdelibs/kdefx/kstyle.cpp makes the change.. Less
> work to patch it here than in Keramik (since keramik doesn't re-implement
> stylehint)

OK, I would say it feels pretty natural. There is only one problem left:
menus that have their first menu point disabled don't have the first enabled
activated. Which brings me to the thought that menus with only disabled items
wouldn't work :)

Other than that I would say commit and we see how many reactions we get.
What do you think? I'm quite pro the change, but would wait for e.g. Karl's 
opinion.

Greetings, Stephan


Comment 6 Maksim Orlovich 2002-12-27 03:03:37 UTC
Subject: Re:  controlling menus with keyboard doesn't skip disabled items

> Other than that I would say commit and we see how many reactions we get.
> What do you think? I'm quite pro the change, but would wait for e.g. Karl's
> opinion.

I personally have no preference on the matter whatsoever; I think it might  be 
worthwhile to ask Aaron Siego's opinion, though, since he seems to be the 
most qualified person to speak of usability... 
(Also, if you meant Karol Szwed - I don't think he is CC'd; I guess I'll ask 
him since he is on IRC right now) 



Comment 7 Karol Szwed 2002-12-27 03:12:35 UTC
> Other than that I would say commit and we see how many reactions we get.  
> What do you think? I'm quite pro the change, but would wait for e.g. Karl's  
> opinion.  
 
I agree with Stephan. Lets give it a go and see what users think. 
 
Comment 8 Maksim Orlovich 2003-01-12 17:02:51 UTC
Subject: kdelibs/kdefx

CVS commit by orlovich: 


Make arrow key navigation skip disabled items.. Comments welcome and encouraged

(Karol: perhaps the rendering of active [due to mouse] menu items in HC should be changed with this. to be more like 
Keramik's?? Also, I guess this is a good reason to port Light2 to KStyle...)


CCMAIL:51446-done@bugs.kde.org


  M +3 -3      kstyle.cpp   1.31


--- kdelibs/kdefx/kstyle.cpp  #1.30:1.31
@@ -1702,4 +1702,5 @@ int KStyle::styleHint( StyleHint sh, con
                 case SH_Slider_SloppyKeyEvents:
                 case SH_MainWindow_SpaceBelowMenuBar:
+                case SH_PopupMenu_AllowActiveAndDisabled:        
                         return 0;
 
@@ -1707,5 +1708,4 @@ int KStyle::styleHint( StyleHint sh, con
                 case SH_PrintDialog_RightAlignButtons:
                 case SH_FontDialog_SelectAssociatedText:
-                case SH_PopupMenu_AllowActiveAndDisabled:
                 case SH_MenuBar_MouseTracking:
                 case SH_PopupMenu_MouseTracking: