Bug 50824 - cvs update to branch fetch list hangs
Summary: cvs update to branch fetch list hangs
Status: RESOLVED FIXED
Alias: None
Product: cervisia
Classification: Applications
Component: general (show other bugs)
Version: 1.5rich1
Platform: Unlisted Binaries Linux
: NOR normal
Target Milestone: ---
Assignee: Bernd Gehrmann
URL:
Keywords:
: 50931 (view as bug list)
Depends on:
Blocks:
 
Reported: 2002-11-16 20:53 UTC by Bob Tanner
Modified: 2003-01-31 13:53 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bob Tanner 2002-11-16 20:53:13 UTC
Version:           1.5rich1 (using KDE 3.0.4)
Compiler:          gcc version 3.2 20020903 (Red Hat Linux 8.0 3.2-7)
OS:          Linux (i686) release 2.4.18-10.realtime

Advanced->Update to Tag/Date...

Check Update to tag, Click Fetch List.

CVS Status window pops up. Displays:

/usr/bin/cvs -f -z3 status -v
cvs server Examining .

Throbber stops. Scrollbar non-responsive.

ps -ef | grep cvs shows it running up and until the throbber stops.
Comment 1 Christian Loose 2002-11-22 10:20:58 UTC
I can confirm this. Tested with current cvs HEAD version.
Comment 2 Christian Loose 2002-12-17 19:51:36 UTC
Subject: KDE_3_1_BRANCH: kdesdk/cervisia

CVS commit by cloose: 

backport from HEAD:
Fixed "fetch of branch list hangs in update dialog" (#50824)

CCMAIL: 50824-done@bugs.kde.org


  M +4 -0      ChangeLog   1.22.2.4
  M +3 -1      cvsprogressdlg.cpp   1.8.2.2
  M +1 -0      cvsprogressdlg.h   1.5.2.1


--- kdesdk/cervisia/ChangeLog  #1.22.2.3:1.22.2.4
@@ -1,2 +1,6 @@
+2002-12-17  Christian Loose <christian.loose@hamburg.de>
+
+        * Fixed "fetch of branch list hangs in update dialog" (#50824)
+
 2002-12-12  Christian Loose <christian.loose@hamburg.de>
 

--- kdesdk/cervisia/cvsprogressdlg.cpp  #1.8.2.1:1.8.2.2
@@ -74,4 +74,5 @@ CvsProgressDialog::CvsProgressDialog(con
     shown = false;
     cancelled = false;
+    hasError = false;
 }
 
@@ -189,4 +190,5 @@ bool CvsProgressDialog::processOutput()
                 {
                     err = true;
+                    hasError = true;
                     resultbox->insertItem(item);
                 }
@@ -235,5 +237,5 @@ void CvsProgressDialog::childExited()
     // error messages or the process has been aborted
     // 'by hand' (e.g.  by clicking the cancel button)
-    if (resultbox->count() < 2 || !childproc->normalExit())
+    if (!hasError || !childproc->normalExit())
         kapp->exit_loop();
 }

--- kdesdk/cervisia/cvsprogressdlg.h  #1.5:1.5.2.1
@@ -57,4 +57,5 @@ private:
     bool shown;
     bool cancelled;
+    bool hasError;
     QString indic1, indic2;
     KProcess *childproc;


Comment 3 Christian Loose 2003-01-31 13:53:09 UTC
*** Bug 50931 has been marked as a duplicate of this bug. ***