Bug 438462 - [Global Design] White transparent overlay for selection of previews changes actual colors
Summary: [Global Design] White transparent overlay for selection of previews changes a...
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kdeclarative
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 5.83.0
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Marco Martin
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2021-06-11 12:10 UTC by postix
Modified: 2021-06-15 14:03 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.84


Attachments
Screenshots: Top: natural appearance, bottom: middle selected, right hovered (82.29 KB, image/png)
2021-06-11 12:10 UTC, postix
Details

Note You need to log in before you can comment on or make changes to this bug.
Description postix 2021-06-11 12:10:37 UTC
Created attachment 139229 [details]
Screenshots: Top: natural appearance, bottom: middle selected, right hovered

In the global design section previews are shown for different themes, symbols etc. 
When you move with the mouse over them, an outline is drawn in a light or a darker color, depending on whether it's just hovered or selected, but additionally a white transparent overlay is added.

This leads to the problem, that no longer the real color appearance is shown, leading to a wrong impression and makes it hard to compare this design to another. Please see the attachment.

I think the outlining already indicates sufficiently what's going on and removing the 'increasing in brightness' would be an enhancement.
Comment 1 Nate Graham 2021-06-14 18:20:02 UTC
Maybe we don't even need it. There's already an appropriate hover border color.
Comment 2 Bug Janitor Service 2021-06-14 18:30:34 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kdeclarative/-/merge_requests/62
Comment 3 Nate Graham 2021-06-15 14:03:12 UTC
Git commit 4b6b17532016a060812fa5c91ff46c144344d094 by Nate Graham.
Committed on 14/06/2021 at 18:30.
Pushed by ngraham into branch 'master'.

[GridDelegate] Remove lightening overlay on hover

This overlay causes the colors of the hovered item to be distorted,
which may be a problem when the content's color matters--for example
when selecting a new color scheme!

There is an outline effect on hover that differs from the selection
effect, so that should be enough to denote that an item is hovered.

Also the lightening effect is is currently hardcoded to not exist on
mobile, so let's just remove it on the desktop view to be consistent.
FIXED-IN: 5.84

M  +5    -9    src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

https://invent.kde.org/frameworks/kdeclarative/commit/4b6b17532016a060812fa5c91ff46c144344d094