Bug 437681 - "Successfully updated n packages" notification following offline update is unnecessary
Summary: "Successfully updated n packages" notification following offline update is un...
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: Updates (offline) (show other bugs)
Version: 5.21.4
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Dan Leinir Turthra Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-25 19:41 UTC by Nate Graham
Modified: 2021-06-14 23:47 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.23


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2021-05-25 19:41:37 UTC
There is almost never a need to notify the user that something succeeded; users expect things to succeed. :) Notifications of success become annoying very quickly, especially if they are seen frequently.

I recommend removing this notification and only notifying if the offline update failed.
Comment 1 Aleix Pol 2021-05-26 02:00:05 UTC
I think it was bhushan who suggested adding it since the alternative is seemingly no changes. I personally don't mind either way.

If it's about the phone, we can have a different setting for the notification there.
Comment 2 Nate Graham 2021-05-26 02:08:24 UTC
I saw this on the desktop. IMO it would be weird on the phone too, but I'll defer to others there.

What wouldn't be weird is showing a window that actually highlights the changes so you can see all the cool new stuff you just got. That would be a whole 'nother kettle of fish, though. :)
Comment 3 Bug Janitor Service 2021-06-14 21:06:59 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/137
Comment 4 Nate Graham 2021-06-14 23:47:22 UTC
Git commit 3f6cfb02f751aa59d9e4bff06964103c37c28a08 by Nate Graham.
Committed on 14/06/2021 at 23:46.
Pushed by ngraham into branch 'master'.

Only show "Successful Offline Update" notification on mobile

In general, our HIG recommends against showing notifications for success,
because the user expects actions that they initiate to succeed. However
apparently things are different in mobile-land, where user expectations
are different.

Therefore, we should only show the "Successful Offline Update"
notification for mobile, where people expect it, and not on the desktop,
where people do not.
FIXED-IN: 5.23

M  +16   -11   libdiscover/backends/PackageKitBackend/PackageKitNotifier.cpp

https://invent.kde.org/plasma/discover/commit/3f6cfb02f751aa59d9e4bff06964103c37c28a08