Bug 397130 - [patch] more psycho-visually-scannable "time to" column in kalarm
Summary: [patch] more psycho-visually-scannable "time to" column in kalarm
Status: CLOSED FIXED
Alias: None
Product: kalarm
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: RedHat Enterprise Linux Linux
: NOR normal
Target Milestone: ---
Assignee: David Jarvie
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-03 16:13 UTC by Robert
Modified: 2021-01-09 17:56 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 18.08.1


Attachments
patch to right-align & zero-pad the hour for "time to" column (1.62 KB, patch)
2018-08-03 16:13 UTC, Robert
Details
screenshot showing the patch effect (23.34 KB, image/png)
2018-08-03 16:13 UTC, Robert
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Robert 2018-08-03 16:13:22 UTC
Created attachment 114289 [details]
patch to right-align & zero-pad the hour for "time to" column

Please consider the attached patch (and/or screenshot) intended to make the "time to" column more readily understandable "en masse" & "at a glance".

Two simple changes:
* right-align the "time to" column
* zero-pad the hour segment (if it will have a number of days before it)

Thanks.
Comment 1 Robert 2018-08-03 16:13:55 UTC
Created attachment 114290 [details]
screenshot showing the patch effect
Comment 2 David Jarvie 2018-08-04 16:05:53 UTC
Thank you for this patch. I think it does improve how "time to" values are displayed.

Apart from some reformatting (adding spaces and removing unnecessary brackets, to make it similar to the existing code), I'm happy with your patch. Do you have KDE commit access, or do you want me to commit it? If the latter, do you want me to attribute the patch to you, with your name and email?
Comment 3 Robert 2018-08-04 16:19:21 UTC
I'm glad you approve!

I do not have commit access, and don't require or object-to attribution... whatever is most convenient.
Comment 4 David Jarvie 2018-08-16 21:56:46 UTC
This has now been committed. The fix will be in version 2.12.1, in KDE Applications 18.08.1 (git commit 56f3d3e4042a19dd6263edfb75613ecf2ece2515).

Thank you.