Bug 36528 - audiocd_slave filename variable configuration
Summary: audiocd_slave filename variable configuration
Status: RESOLVED FIXED
Alias: None
Product: kio
Classification: Frameworks and Libraries
Component: audiocd (show other bugs)
Version: unspecified
Platform: Debian testing Linux
: NOR wishlist
Target Milestone: ---
Assignee: rik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2001-12-27 07:18 UTC by Certron 80
Modified: 2003-04-19 06:29 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Certron 80 2001-12-27 07:12:37 UTC
(*** This bug was imported into bugs.kde.org ***)

Package:           konqueror
Version:           KDE 2.2.2 
Severity:          wishlist
Installed from:    Debian testing/unstable Packages
Compiler:          Not Specified
OS:                Linux
OS/Compiler notes: Not Specified

I want to be able to configure the filename that is made when encoding ogg or mp3 from the audiocd ioslave. Something like how grip has it set up where fields and characters can be defined. just add a tab basically or add it in with the cddb tab since it will use that info. I don't want just tracknum and title i want artist and title and maybe album. look at grip. oh and kde rocks.

(Submitted via bugs.kde.org)
Comment 1 Adam Piontek 2003-01-08 19:52:52 UTC
I'll second this - the audiocd KIOSlave needs to have some way, probably in a 
tab next to the CDDB settings, to configure what tags are added to the Oggs & 
MP3s, and to configure how the files are named.

This way, after copying over the files (encoding the Oggs (or MP3s)), one 
doesn't have to go through and rename each file, and re-tag each file.

It should also allow the files to be renamed before they are copied, and try to 
guess the correct tag information from how they are renamed, perhaps according 
to wildcard settings in the abovementioned tab in the Control Center.

For example, if I put in a CD and access it with audiocd:/ - it goes to the 
CDDB and gets the track info, and if I want it to display Oggs like so:

01 - Aphex Twin - On.ogg
02 - Aphex Twin - Xepha.ogg
03 - Aphex Twin - Nannou.ogg

I should be able to configure it.  And what if the information that the CDDB 
downloads is wrong?  I often see misspellings, and it's easier to correct that 
once before encoding and tagging, so that the filename and tags are all 
correct, rather than waiting until it's all done and then fixing the filename 
and all the tags.  So for example, if the Ogg is displayed in audiocd:/ like so:

01 - Aphoox Twin - Come to Daiddy.ogg

I should be able to rename it in audiocd:

01 - Aphex Twin - Come to Daddy.ogg

And then copy it over, and have audiocd correctly tag the file with:

Track: 01
Artist: Aphex Twin
SongTitle: Come to Daddy

etc...  It would be nice if it could be set in the Control Center to get the 
album title from the folder, or something, maybe another folder inside the Ogg 
folder, like:

audiocd:/Ogg/Come to Daddy/01 - Aphex Twin - Come to Daddy.ogg

Basically, it should be very flexible and configurable, even to the extreme, 
like somebody would probably like to be able to have:

audiocd:/Ogg/Aphex Twin [1997] Come to Daddy/01 - Come to Daddy.ogg

And audiocd should know, from user configuration in the Control Center, to tag 
the file like so:

Artist: Aphex Twin
Album: Come to Daddy
Year: 1997
Track: 01
SongTitle: Come to Daddy

Definitely check out the flexibility of Grip - I realize perhaps audiocd is 
just intended to be a quick hack for simple ripping, but I don't see why it 
couldn't be given the expanded ability to be configured by advanced users, 
while still offering the current behavior as the default for quick & easy basic 
encoding.
Comment 2 jeremyhu 2003-01-08 22:33:07 UTC
Can someone mark 31883 as a dup of this?

While I think it would be great to be able to change the information retrieved 
from CDDB (and additionally save the changes to your local copy of the 
database), I think that changing this by modifying the filename to some set 
format is a rather unattractive option.  String parsing with a user configured 
format will undoubtedly lead to language ambiguity (and by language, I mean in 
lexical analysis, not written word).

I have resigned myself to accepting the default string format and created 
sudirectories for each artist/cd manualy, but that still doesn't solve the 
problem with illegal characters (FAT32) in the title or filename size 
restriction (ISO CDs are restricted to less characters than most filesystems) 
which I think should be addressed as well.

It would be nice to have, in the control panel, a section for character 
replacements on a per-character level (ie, don't just replace all illegal 
characters with _.  Let the user decide how to replace each character she 
determines to be illegal).

Additionally, create a field to set the maximum filename size, and truncate the 
filename so that you can still fit in the extension.

Now, I have a local copy of CDDB that I update whenever I find problems with 
filenames or ambiguous albums.  It would be nice if audiocd's CDDB support were 
improved.  Once audiocd determines the CD's ID, it just picks an entry from 
CDDB with that same ID rather than prompting the user to select which album to 
use.  I realize that this is quite difficult to do with the ioslave interface, 
so I think it would be a good idea to use a companion program to allow users 
more control over CDDB information (choosing which album, creating new entries, 
and editing incorrect entries), and a simple f5 refresh in the konq window will 
reflect the changes.
Comment 3 thebeast 2003-01-22 23:32:37 UTC
http://bugs.kde.org/show_bug.cgi?id=40272 is kind of related, no?
Comment 4 Scott Wheeler 2003-04-19 06:29:48 UTC
Subject: kdemultimedia/kioslave/audiocd [POSSIBLY UNSAFE]

CVS commit by wheeler: 

Implemented #36528 -- Allow the file names for the audiocd IO slave to be 
configurable.  Also switched the KCM over to using KConfigGroupSaver while
while I was at it.

CCMAIL:36528-done@bugs.kde.org


  M +22 -4     audiocd.cpp   1.74 [POSSIBLY UNSAFE: printf]
  M +68 -0     kcmaudiocd/audiocdconfig.ui   1.25
  M +157 -126  kcmaudiocd/kcmaudiocd.cpp   1.33