Per downstream reports, https://bugzilla.redhat.com/show_bug.cgi?id=1310393 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=771191 calligra currently includes a nonfree image, lena*.png in sources "calligra-2.9.11/krita/plugins/filters/tests/data/lena*.png" "calligra-2.9.11/krita/ui/test/data/lena.png" "calligra-2.9.11/krita/sdk/test/data/lena.png" "calligra-2.9.11/krita/plugins/tools/defaulttools/tests/data/lena*.png" which does not comply with https://techbase.kde.org/Policies/Licensing_Policy See also: https://en.wikipedia.org/wiki/File:Lenna.png#Licensing https://lintian.debian.org/tags/license-problem-non-free-img-lenna.html Reproducible: Always
Yeah, we've noticed. We're in a busy moment and that's a hella lot of tests that rely on it, so we're trying to figure out a spot in our schedule when to tackle it. We're not even sure how it got in 4 whole times...
Alright... UI uses her for... filter_stroke_test.cpp kis_prescaled_projection_test.cpp Tools uses her for... move_stroke_test.cpp filters uses her for kis_all_filter_test.cpp kis_crash_filter_test.cpp SDK... doesn't use her at all...
Git commit 1d474794bf2503c0b23e70418a2785f6e8def779 by Wolthera van Hövell. Committed on 21/02/2016 at 16:38. Pushed by woltherav into branch 'master'. Remove lena.png from sdk. 1/4 lenas removed. I don't know enough about tests to dare tackling the others, but this one seemed easy enough. D +- -- sdk/tests/data/lena.png http://commits.kde.org/krita/1d474794bf2503c0b23e70418a2785f6e8def779
Hi, Wolthera! The images in sdk/tests/data were my attempt not to store the data in every testing directory and fetch them from a centralized storage via TestUtil::fetchDataFileLazy(). According to grep lena.png was not used this way, so the commit is safe. The rest of the usages weem to be not very difficult to fix libs/ui/tests/filter_stroke_test.cpp: QImage src(QString(FILES_DATA_DIR) + QDir::separator() + "lena.png"); libs/ui/tests/kis_animation_importer_test.cpp: files.append(QString(FILES_DATA_DIR) + QDir::separator() + "lena.png"); libs/ui/tests/kis_animation_importer_test.cpp: QImage source2(QString(FILES_DATA_DIR) + QDir::separator() + "lena.png"); libs/ui/tests/kis_prescaled_projection_test.cpp: QImage qimage(QString(FILES_DATA_DIR) + QDir::separator() + "lena.png"); libs/ui/tests/kis_prescaled_projection_test.cpp: QImage qimage(QString(FILES_DATA_DIR) + QDir::separator() + "lena.png"); libs/ui/tests/kis_prescaled_projection_test.cpp: QImage referenceImage(QString(FILES_DATA_DIR) + QDir::separator() + "lena.png"); libs/ui/tests/kis_prescaled_projection_test.cpp: sourceImage = QImage(QString(FILES_DATA_DIR) + QDir::separator() + "lena.png"); plugins/filters/tests/kis_all_filter_test.cpp: QImage qimage(QString(FILES_DATA_DIR) + QDir::separator() + "lena.png"); plugins/filters/tests/kis_all_filter_test.cpp: QImage qimage(QString(FILES_DATA_DIR) + QDir::separator() + "lena.png"); plugins/filters/tests/kis_all_filter_test.cpp: QImage qimage(QString(FILES_DATA_DIR) + QDir::separator() + "lena.png"); plugins/filters/tests/kis_all_filter_test.cpp: QImage qimage(QString(FILES_DATA_DIR) + QDir::separator() + "lena.png"); plugins/filters/tests/kis_crash_filter_test.cpp: QImage qimage(QString(FILES_DATA_DIR) + QDir::separator() + "lena.png"); plugins/tools/basictools/tests/move_stroke_test.cpp: QImage src(QString(FILES_DATA_DIR) + QDir::separator() + "lena.png");
Fixed now, in 8fc80f0360dc1ee0c8ce48abcb9f7013917780a6 and 134a00200eeda0b3d5d3ee9b598879a94e48797c