Bug 356398 - migrated kickofff favorites include only last item
Summary: migrated kickofff favorites include only last item
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Application Menu (Kicker) (show other bugs)
Version: 5.5.0
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Eike Hein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-08 19:21 UTC by Rex Dieter
Modified: 2015-12-09 15:49 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rex Dieter 2015-12-08 19:21:10 UTC
upgrading from 5.4.3 -> 5.5.0 seems to result in an incomplete migration of kickoff favorites, seeing only one (the last one) favorite after upgrading.

Guessing that there's some bug in the migration script,
/usr/share/plasma/shells/org.kde.plasma.desktop/contents/updates/obsolete_kickoffrc.js

Reproducible: Always
Comment 1 Eike Hein 2015-12-08 19:27:07 UTC
Git commit 97ced66da372737ae5d36d86c9bc0c6fe684d842 by Eike Hein.
Committed on 08/12/2015 at 19:26.
Pushed by hein into branch 'Plasma/5.5'.

Fix migration of multiple favorites.

M  +1    -1    desktoppackage/contents/updates/obsolete_kickoffrc.js

http://commits.kde.org/plasma-desktop/97ced66da372737ae5d36d86c9bc0c6fe684d842
Comment 2 Rex Dieter 2015-12-09 13:49:04 UTC
Would it make sense also to rename obsolete_kickoffrc.js to force it to run again for folks who used the prior buggy one?
Comment 3 Eike Hein 2015-12-09 13:59:15 UTC
I considered that, but it would undo any manual fixups, too. Not sure. We might have caught it early enough? I also mailed the distro/packager list about it.
Comment 4 Rex Dieter 2015-12-09 14:01:21 UTC
OK, I was just implementing that in our (fedora) packaging to avoid having to tell all testers of workarounds, thought it may make sense upstream too.  But, I can see doing it upstream may make less sense (since many 5.5.0 users won't see it until 5.5.1 lands)
Comment 5 Eike Hein 2015-12-09 15:49:42 UTC
Yeah, and if we ship it renamed in 5.5.1 we undo changes again.