Bug 34361 - incorrect rendering of images when scaled using a percentage
Summary: incorrect rendering of images when scaled using a percentage
Status: RESOLVED FIXED
Alias: None
Product: konqueror
Classification: Applications
Component: khtml (show other bugs)
Version: 3.0
Platform: Debian testing Linux
: NOR normal
Target Milestone: ---
Assignee: Dirk Mueller
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2001-11-01 16:48 UTC by spark
Modified: 2003-01-06 16:04 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description spark 2001-11-01 16:44:55 UTC
(*** This bug was imported into bugs.kde.org ***)

Package:           khtml
Version:           3.0 (using KDE 2.2.1 )
Severity:          normal
Installed from:    Debian Package 4:2.2.1-11 (testing/unstable)
Compiler:          gcc version 2.95.4 20011006 (Debian prerelease)
OS:                Linux (i686) release 2.4.11
OS/Compiler notes: 

When using a percentage to specify the height of an image it gets scaled relative to the original size of the image. According to the html 4.01 specifications the image should scale relative to the amount of space available (for example the amount of space available in a table cell).

(Submitted via bugs.kde.org)
(Called from KBugReport dialog)
Comment 1 Dirk Mueller 2002-11-22 04:15:27 UTC
I don't think this is the case. No testcase, closing.  
Comment 2 Jelmer Feenstra 2002-11-25 19:01:35 UTC
Subject: Re:  incorrect rendering of images when scaled using a percentage

On Friday 22 November 2002 04:15, you wrote:

> ------- Additional Comments From mueller@kde.org  2002-11-22 04:15 -------
> I don't think this is the case. No testcase, closing.

The behaviour is even worse now, when using the HEIGHT property for the image 
(test.png) in the testcase below, khtml doesn't show the image at all when 
rendering. Using a percentage of 100 for the width of the image however, 
shows the image correctly scaled in both directions. So, there still seems to 
be a problem with the scaling (or the cell contents size).

Jelmer

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN"
   "http://www.w3.org/TR/html4/strict.dtd">
<HTML>
   	<HEAD>
		<TITLE>My first HTML document</TITLE>
   	</HEAD>

	<BODY>
	<TABLE>
		<TD WIDTH=512 HEIGHT=512 VALIGN=TOP >
			<IMG SRC="test.png" HEIGHT="10%"></IMG>
	</TABLE>
	<P>Hello world!	
	</BODY>
</HTML>

Comment 3 Dirk Mueller 2002-12-30 22:52:26 UTC
unfixed 
Comment 4 Dirk Mueller 2003-01-06 16:04:16 UTC
Subject: kdelibs/khtml/rendering

CVS commit by mueller: 

make percentage height on images work again. 
CCMAIL: 34361-done@bugs.kde.org


  M +14 -2     render_body.cpp   1.21
  M +3 -3      render_body.h   1.11
  M +16 -64    render_box.cpp   1.186
  M +2 -2      render_box.h   1.58
  M +3 -20     render_form.cpp   1.205
  M +1 -5      render_form.h   1.79
  M +1 -21     render_frames.cpp   1.145
  M +1 -6      render_frames.h   1.48
  M +2 -5      render_html.cpp   1.25
  M +21 -19    render_html.h   1.11
  M +29 -2     render_image.cpp   1.101
  M +4 -2      render_image.h   1.37
  M +2 -1      render_object.cpp   1.198
  M +3 -4      render_replaced.cpp   1.106
  M +2 -2      render_replaced.h   1.40
  M +2 -2      render_root.cpp   1.121
  M +2 -2      render_text.cpp   1.197