Bug 328380 - Add support for pqxx 4.0.1 library
Summary: Add support for pqxx 4.0.1 library
Status: CLOSED FIXED
Alias: None
Product: KEXI
Classification: Applications
Component: Migration/Import/Export (show other bugs)
Version: 2.7.5
Platform: Debian unstable Linux
: NOR normal
Target Milestone: 2.8
Assignee: Jarosław Staniek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-03 12:59 UTC by Maximiliano Curia
Modified: 2013-12-08 14:00 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 2.8.0


Attachments
Patch to remove the MAX_VERSION checks (3.57 KB, patch)
2013-12-03 13:00 UTC, Maximiliano Curia
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Maximiliano Curia 2013-12-03 12:59:01 UTC
Debian replaced the libpqxx with the 4.0.1 version, making calligra to fail to build. I was willing to migrate the code to libpqxx 4.0.1 but then after reverting the MAX_VERSION checks I got no warnings or errors. And after a minimal test against a postgresql kexi db it seems to be working as expected.

The MAX_VERSION checks were introduced here: https://bugs.kde.org/show_bug.cgi?id=300871#c1

So, if kexi uses only the parts of the API that remained stable when switching form 3.1 to 4.0.1 please revert the MAX_VERSION check.

If I'm failing to test the right features, please let me know what should I test.

Reproducible: Always
Comment 1 Maximiliano Curia 2013-12-03 13:00:47 UTC
Created attachment 83896 [details]
Patch to remove the MAX_VERSION checks

Trivial patch that reverts the PQXX_MAX_VERSION checks.
Comment 2 Jarosław Staniek 2013-12-07 11:42:14 UTC
Git commit 9cb0f5f3c0b918c114b54a0cc8f30bf1f6c3240d by Jaroslaw Staniek.
Committed on 07/12/2013 at 11:40.
Pushed by staniek into branch 'master'.

Kexi postgresql driver: enable use of pqxx 4.x

M  +1    -1    kexi/CMakeLists.txt

http://commits.kde.org/calligra/9cb0f5f3c0b918c114b54a0cc8f30bf1f6c3240d
Comment 3 Jarosław Staniek 2013-12-07 11:48:33 UTC
Git commit 3b307e34fe620d80ba66c29df7a257c45c842bbb by Jaroslaw Staniek.
Committed on 07/12/2013 at 11:40.
Pushed by staniek into branch 'calligra/2.8'.

Kexi postgresql driver: enable use of pqxx 4.x

M  +1    -1    kexi/CMakeLists.txt

http://commits.kde.org/calligra/3b307e34fe620d80ba66c29df7a257c45c842bbb