Bug 296362 - after last update of oxygen-gtk for kde , evolution background shouldn't be gray
Summary: after last update of oxygen-gtk for kde , evolution background shouldn't be gray
Status: CLOSED FIXED
Alias: None
Product: Oxygen
Classification: Plasma
Component: gtk3-engine (show other bugs)
Version: unspecified
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: Hugo Pereira Da Costa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-19 14:46 UTC by SP
Modified: 2012-05-15 04:06 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
image of gtk3 background anomaly with evolution and nautilus (738.30 KB, image/png)
2012-03-22 15:15 UTC, SP
Details

Note You need to log in before you can comment on or make changes to this bug.
Description SP 2012-03-19 14:46:20 UTC
After updates on 03-18-2012 the message list and message windows on the right part of the Evolution mail read appear grey.  They should not be grey.  
Relevant components:
oxygen-cursor-themes-4.8.1-6.fc16.noarch.rpm
oxygen-gtk-1.2..0-2.fc16
oxygen-gtk2-1.2.2-1.fc16
oxygen-gtk3-1.0.1-1.fc16
oxygen-icon-theme-4.8.1-1.fc16.noarch.rpm

This bug has also been reported by others at:
https://bugzilla.redhat.com/show_bug.cgi?id=804455
Comment 1 Ruslan Kabatsayev 2012-03-19 18:32:57 UTC
In fact, this isn't related to updates. It has always been so with oxygen-gtk. Now, I'm not sure what we are doing wrong. At the top of our color configuration we set default colors for "*" section. If I comment this out, MessageList and mail preview becomes white, but some background colors are wrong.
But what correct section should be used for MessageList and preview window? If I add MessageList to the same section as .view, then its background is white, but the rows still remain in wrong color...
Comment 2 Sérgio Basto 2012-03-19 19:24:29 UTC
(In reply to comment #1)
> Now, I'm not sure what we are doing wrong. At the top of our
> color configuration we set default colors for "*" section. If I comment this
> out, MessageList and mail preview becomes white, but some background colors
> are wrong.

where is " our  color configuration" ? 

> But what correct section should be used for MessageList and preview window?
> If I add MessageList to the same section as .view, then its background is
> white, but the rows still remain in wrong color...

I don't have any idea what you are talking about , but if you modify default configuration , I 'd like try previous one.
Comment 3 Ruslan Kabatsayev 2012-03-19 19:44:24 UTC
> where is " our  color configuration" ? 
It's generated dynamically in oxygenqtsettings.cpp lines 601-718
> I 'd like try previous one.
Try removing three lines about from line 617, and you'll see why we change defaults.

The correct solution for this would be finding general enough section name for the widgets affected by this bug, independent of widget name (like we use .view instead of GtkTreeView, GtkIconView etc.).
Comment 4 SP 2012-03-19 20:16:55 UTC
(In reply to comment #3)
> > where is " our  color configuration" ? 
> It's generated dynamically in oxygenqtsettings.cpp lines 601-718
Is this a build configuration file?   I have searched for it but it does not appear to exist as a kde configuration file on my computer.
Comment 5 Sérgio Basto 2012-03-20 01:04:51 UTC
other background which isn't correct is the background of Firefox , 
right-clik-> view image , the background is a dark gray.
on Seamonkey the background is the correct white.
Comment 6 nucleo 2012-03-20 03:02:48 UTC
(In reply to comment #5)
> other background which isn't correct is the background of Firefox , 
> right-clik-> view image , the background is a dark gray.
> on Seamonkey the background is the correct white.

This is not related with this bug. Firefox and Seamonkey are gtk2 apps but Evolution uses gtk3.
Background changed in Firefox 11 and it will be the same in Seamoney if you update it to 2.8.
Comment 7 SP 2012-03-20 14:28:37 UTC
(In reply to comment #1)
> In fact, this isn't related to updates. It has always been so with
> oxygen-gtk. 

No - this only appeared on the updates of 03-18-2012.  I have used oxygen-gtk for a while in kde and the evolution mail reader has always had a white message background and a message list with alternate white and shaded lines.  Currently the mail folder list appears correctly but the message list and message read and compose windows are in grey.
It would seem that something was changed in the last package update that caused this.  So "oxygenqtsettings.cpp" is part of a source file?  Which source file should I download to look at it?
Comment 8 nucleo 2012-03-20 14:35:35 UTC
(In reply to comment #7)
> (In reply to comment #1)
> > In fact, this isn't related to updates. It has always been so with
> > oxygen-gtk. 
> 
> No - this only appeared on the updates of 03-18-2012.  I have used
oxygen-gtk3 installed first with this update.
Are you sure that oxygen-gtk3 theme was used in Evolution before this update?
Comment 9 Ruslan Kabatsayev 2012-03-20 14:47:50 UTC
> No - this only appeared on the updates of 03-18-2012.
As nucleo says, before updates you might have been using evolution based on gtk2. gtk3-based one had another, more serious problem some oxygen versions ago. And I haven't ever seen it have correct bg color with oxygen-gtk3.
Comment 10 nucleo 2012-03-20 14:50:09 UTC
Evolution itself gtk3-based, so I assume that before last large KDE update Adwaita theme was used there.
Comment 11 SP 2012-03-20 15:43:54 UTC
(In reply to comment #10)
> Evolution itself gtk3-based, so I assume that before last large KDE update
> Adwaita theme was used there.

Ah - OK - you are probably right.  I thought things looked generally better - except for the grey backgrounds.  Swings and roundabouts;)
Comment 12 SP 2012-03-21 01:54:24 UTC
(In reply to comment #9)
> > No - this only appeared on the updates of 03-18-2012.
> As nucleo says, before updates you might have been using evolution based on
> gtk2. gtk3-based one had another, more serious problem some oxygen versions
> ago. And I haven't ever seen it have correct bg color with oxygen-gtk3.

Now I see that running Nautilus in KDE has the same effect,  Bookmarks/Computer list on the left as it should be - white background with default folder colours - whereas the right window with folder/file view has a grey background.  So this applies to all Gnome applications opened in the KDE environment with gtk3  that have sectioned windows.
Comment 13 SP 2012-03-22 15:15:44 UTC
Created attachment 69814 [details]
image of gtk3 background anomaly with evolution and nautilus
Comment 14 SP 2012-03-22 15:22:06 UTC
(In reply to comment #13)
> Created attachment 69814 [details]
> image of gtk3 background anomaly with evolution and nautilus
This image was intended for the comment below - (which got lost with the attachment.)  The recent update - oxygen-gtk3-1.0.2-2.f16 has fixed the grey screen on the right of nautilus in kde which now appears with the correct background.  Evolution, however, still has the grey screen on the right.  Is an application-specific configuration required?  Which config file should one edit - kdeglobals, gtk.css  or argb-apps.conf?
(see image)
Comment 15 Hugo Pereira Da Costa 2012-03-22 15:54:39 UTC
first you should look if there is anything in "$HOME/.config/gtk-3.0/gtk.css"
(mine is empty)

then the only other places where color changes are done is programatically in oxygen-gtk/src/oxygenqtsettings.cpp

The method is: QtSettings::generateGtkColors, which assigns colors to gtk widgets based on the kdeglobals palette. 

You can also try add things manually to gtk.css (either the one in your home directory, or the one installed with oxygen-gtk), but there you would only be able to set "hard coded" colors, and not the ones that match your kde palette.
Comment 16 nucleo 2012-03-22 16:31:07 UTC
FYI: oxygen-gtk3-1.0.2-2.f16 built with -DENABLE_INNER_SHADOWS_HACK=0 (workaround for bug 295831)
Comment 17 Hugo Pereira Da Costa 2012-03-22 16:34:16 UTC
@ Nucleo
yes, that was the most sensible thing to do for the packagers.
Now: it is fixed in our code (and will be included in next release)
Also, many other issues (with gtk3.3) have been fixed. Should look better hopefully.
Like always, your feedback is welcome ;)
Comment 18 SP 2012-03-22 17:51:23 UTC
(In reply to comment #15)
> first you should look if there is anything in "$HOME/.config/gtk-3.0/gtk.css"
> (mine is empty)
> 
> then the only other places where color changes are done is programatically
> in oxygen-gtk/src/oxygenqtsettings.cpp
> 
> The method is: QtSettings::generateGtkColors, which assigns colors to gtk
> widgets based on the kdeglobals palette. 
> 
> You can also try add things manually to gtk.css (either the one in your home
> directory, or the one installed with oxygen-gtk), but there you would only
> be able to set "hard coded" colors, and not the ones that match your kde
> palette.

The configuration files (in Fedora) are placed in /usr/share/themes/oxygen-gtk/gtk-3.0. Making a symlink to .config is a matter of convenience.  But it is good to hear that this is all fixed in gtk3.3.
Comment 19 Sérgio Basto 2012-03-24 11:42:00 UTC
where is gtk3.3 for Fedora ?  16 or >=17
Comment 20 SP 2012-03-31 15:20:30 UTC
The background problem in Evolution persists in the recent update of oxygen-gtk3 1.9.2.1-1.fc16
Message list and message view/compose windows appear with a grey background - should be white or user's default.
Comment 21 Hugo Pereira Da Costa 2012-03-31 18:15:27 UTC
Not really surprising, since none of the changes (in either oxygen-gtk2 or oxygen-gtk3) did try to address this issue (we'd need to reproduce first, which I can't at the moment). These changes addressed stability issues and more serious rendering issues with gtk3.3 (and it turns out, with gtk3.4 too. Good news is: not everything got broken again with gtk3.4, which I'm running on now).

Patience ...
Comment 22 SP 2012-03-31 19:43:52 UTC
@Hugo - We humble consumers wait with bated breath.  Your work is nevertheless greatly appreciated and I am sure I speak for all.
Comment 23 nucleo 2012-04-15 13:13:41 UTC
Looks like bug fixed in 1.0.3?
http://lists.fedoraproject.org/pipermail/test/2012-April/106914.html
Comment 24 Ruslan Kabatsayev 2012-04-15 13:31:52 UTC
Yes, it is, thanks to Hugo.
Comment 25 SP 2012-04-15 15:04:17 UTC
That's great news and thank you, Hugo.  Will it be released as an F16 package update, too?
Comment 26 SP 2012-04-15 15:05:53 UTC
That's great news and thank you, Hugo.  Will it be released as an F16 package update, too?
Comment 27 nucleo 2012-04-15 15:06:46 UTC
(In reply to comment #25)
> Will it be released as an F16 package update, too?
1.0.3 in updates-testing
Comment 28 SP 2012-04-24 21:41:02 UTC
Have now downloaded 1.0.3 with the latest kernel for general release.  Marvelous!  Thanks again, Hugo.