Bug 284316 - Git plugin stops displaying git information after a file search
Summary: Git plugin stops displaying git information after a file search
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: plugins: git (show other bugs)
Version: 1.7
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-18 01:43 UTC by James Roe
Modified: 2018-04-15 16:04 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description James Roe 2011-10-18 01:43:30 UTC
Version:           1.7 (using KDE 4.7.2) 
OS:                Linux

When using the git plugin with a git repo, git information display for our git working directory stops working after a file search in a subdirectory of the project.

Reproducible: Always

Steps to Reproduce:
When using the git plugin with a git repo, in a subdirectory (this doesn't work for the main directory where the .git dir is), do a file search for anything that will match a file(s), then press the close button on the search. The git information display for project files/directories is now gone. Going back up the directory tree back to the directory where the .git dir is brings back the information display. This may affect other software versioning plugins as well (shouldn't affect SVN though since .svn directories are in each folder of the project).

Actual Results:  
Git display stops showing the git information for the files and stuff.

Expected Results:  
Git display continues showing git information for the files and stuff.
Comment 1 Peter Penz 2011-10-18 07:39:45 UTC
Thanks for the report. This issue is a known compromise between speed and correctness: Per default Dolphin only checks the current directory for .git, .svn, ... directories. It would be too expensive to check all parent directories for those files when entering any directory. But there might be room for improvements like in situations you describe (e.g. Dolphin has the history and could be clever enough to check this).
Comment 2 Sebastian Dörner 2011-12-29 23:55:28 UTC
While there are certainly the limitations Peter described (e.g. you have to visit the top level directory once before any version control information is shown), I can't reproduce the exact error you describe.

You go to a subdirectory (VC information is shown).
Do a file search (with files found).
Then press the red "x" to close the file search.
Afterwards I do get the VC information again (whereas you don't if I understood correctly).

Can you still reproduce it with KDE 4.7.4?
Comment 3 James Roe 2012-02-14 19:48:41 UTC
Yes, I can reproduce it in that exact order with KDE 4.7.4 on Kubuntu 11.10, using Git.
Comment 4 Jeroen van Meeuwen (Kolab Systems) 2012-08-24 16:18:37 UTC
Resetting assignee to default as per bug #305719
Comment 5 Adrián Chaves (Gallaecio) 2012-11-01 19:02:56 UTC
I cannot reproduce it either, in my case with KDE 4.9.2, Dolphin 2.1.

The steps I followed:
1. Enable Dolphin’s Git extension: Go to Control → Configure Dolphin… → Services, mark the Git entry, and click Accept. Then restart Dolphin.
2. Go into an empty folder (created for this test) that is indexed by Nepomuk, open Dolphin’s terminal, and run:

    git init
    mkdir folder1
    touch folder1/a

3. Enter into folder1. “a” should have a mark that confirms Dolphin successfully detects this being inside of a Git repository.
4. Start a search (Ctrl+F) using the following criteria:
    4.1. “a” as the search term.
    4.2. “Filename” option selected.
    4.3. “From Here (folder1)” option selected (default).
5. If you get no results, it might be because “a” has not yet been indexed by Nepomuk. Just repeat the steps from 4.
6. Click the red X in the top-right corner of the main view, to stop the search and get back to the folder you were at (folder1).

According to your report, the VCS icons will not be over the file icons at this point. However, they are for me.

Can you reproduce the issue with these steps in Dolphin 2.1?
Comment 6 Julian Steinmann 2018-03-30 09:38:49 UTC
@James Roe, can you reproduce this bug in a newer version of Dolphin? If not, I'll close this bug soon.
Comment 7 Julian Steinmann 2018-04-15 16:04:09 UTC
No response -> closing. Thanks for reporting this bug, please reopen the report if you can still reproduce this behavior with newer versions of Dolphin.