Bug 283246 - Some text is hard to read with dark color theme
Summary: Some text is hard to read with dark color theme
Status: RESOLVED FIXED
Alias: None
Product: skrooge
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Stephane MANKOWSKI
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-03 12:57 UTC by Jure Repinc
Modified: 2011-10-03 14:55 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
dashboard (203.60 KB, image/png)
2011-10-03 13:07 UTC, Jure Repinc
Details
operations (160.04 KB, image/png)
2011-10-03 13:08 UTC, Jure Repinc
Details
colors-settings (84.83 KB, image/png)
2011-10-03 13:09 UTC, Jure Repinc
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jure Repinc 2011-10-03 12:57:27 UTC
Version:           unspecified (using KDE 4.7.1) 
OS:                Linux

In KDE I'm using a dark color theme called Obsidian Coast. It looks like for some parts of Skrooge the system theme colors are not respected. Most common cases are ammounts of money which are always black when positive and always red when negative. It looks like for these ammounts the colors are hardcoded while Skrooge should use the specific colors for this from system color theme.

Reproducible: Always

Steps to Reproduce:
1. Select a dark theme in KDE System Settings → Application Look → Colors
2. Open Skrooge and observe text colors of some ammounts, for example on Dashboard Accounts or status in Operations page

Actual Results:  
The positive amounts are always black which is hard to read on dark application background. Negative amounts are always red.

Expected Results:  
For these parts a special color from the system color theme should be used (positive, negative, neutral text color).
Comment 1 Jure Repinc 2011-10-03 13:07:56 UTC
Created attachment 64162 [details]
dashboard

Screenshot of dashboard with problematic text marked
Comment 2 Jure Repinc 2011-10-03 13:08:41 UTC
Created attachment 64163 [details]
operations

Screenshot of operations with problematic text marked
Comment 3 Jure Repinc 2011-10-03 13:09:53 UTC
Created attachment 64164 [details]
colors-settings

Settings for colors where colors for negative and positive text are defined
Comment 4 Stephane MANKOWSKI 2011-10-03 14:55:09 UTC
Git commit 3095f09ddfe4d225afa56770f4701612a1c4bfdd by Stephane Mankowski.
Committed on 03/10/2011 at 16:54.
Pushed by smankowski into branch 'master'.

BUG: 283246: Some text is hard to read with dark color theme

M  +1    -0    CHANGELOG
M  +9    -1    plugins/applet/alarm/alarmskroogoid.cpp
M  +7    -5    plugins/skrooge/skrooge_bank/skgaccountboardwidget.cpp
M  +3    -4    plugins/skrooge/skrooge_bank/skgbankboardwidget.cpp
M  +10   -9    plugins/skrooge/skrooge_operation/skgoperationpluginwidget.cpp
M  +8    -1    plugins/skrooge/skrooge_search/skgalarmboardwidget.cpp
M  +4    -8    plugins/skrooge/skrooge_unit/skgunitboardwidget.cpp
M  +1    -2    skgbankgui/skgobjectmodel.cpp
M  +0    -1    skgbankgui/skgobjectmodel.h
M  +17   -2    skgbankmodeler/skgdocumentbank.cpp
M  +2    -1    skgbasegui/skgcalculatoredit.cpp
M  +6    -1    skgbasegui/skgobjectmodelbase.cpp
M  +5    -0    skgbasegui/skgobjectmodelbase.h
M  +4    -2    skgbasegui/skgtablewithgraph.cpp
M  +1    -0    skgbasegui/skgtablewithgraph.h

http://commits.kde.org/skrooge/3095f09ddfe4d225afa56770f4701612a1c4bfdd