Bug 278348 - Grey Search Boxes In Icedove/Thunderbird
Summary: Grey Search Boxes In Icedove/Thunderbird
Status: CLOSED FIXED
Alias: None
Product: Oxygen
Classification: Plasma
Component: gtk2-engine (show other bugs)
Version: unspecified
Platform: Debian stable Linux
: NOR normal
Target Milestone: ---
Assignee: Hugo Pereira Da Costa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-23 17:10 UTC by Marcus
Modified: 2011-09-13 22:23 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
screenshot of the grey search box background color (3.62 KB, image/png)
2011-07-23 17:10 UTC, Marcus
Details
my screenshot (with latest oxygen-gtk from "master") and thunderbird 5.0 (13.39 KB, image/png)
2011-07-25 15:02 UTC, Hugo Pereira Da Costa
Details
another screenshot showing some more crippled elements (47.53 KB, image/png)
2011-08-08 18:17 UTC, Marcus
Details
debug during start of iceweasel/thunderbird (101.38 KB, text/plain)
2011-08-08 19:47 UTC, Marcus
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Marcus 2011-07-23 17:10:54 UTC
Created attachment 62123 [details]
screenshot of the grey search box background color

Version:           unspecified (using KDE 4.4.5) 
OS:                Linux

The searchboxes in Icedove/Thunderbird have a grey background color instead of white.

Reproducible: Didn't try

Steps to Reproduce:
Use Icedove/Thunderbird with latest oxygen-gtk


Expected Results:  
Search boxes should have white bg-color
Comment 1 Hugo Pereira Da Costa 2011-07-25 15:02:21 UTC
Created attachment 62183 [details]
my screenshot (with latest oxygen-gtk from "master") and thunderbird 5.0

Can't reproduce ...
Which thunderbird version do you use ? 
and which oxygen-gtk version is it ?

Thanks
Comment 2 Marcus 2011-07-25 16:07:03 UTC
I am using Thunderbird 3.1.11 and have tried oxygen-gtk 1.0.5 and 1.1.1.
Comment 3 Hugo Pereira Da Costa 2011-07-25 21:13:19 UTC
... mmm just installed thunderbird 3.1.11 and oxygen-gtk-1.1.1 and still can't reproduce. There might be some fancy (and incorrect) things in your various .gtkrc files, and/or possibly in thunderbird theme (make sure you use none).
Comment 4 Marcus 2011-08-08 17:52:11 UTC
Hmm, strange. I am not using any Thunderbird themes, but I have used gtk-qt-theme-engine to activate oxygen-gtk.

Could that perhaps be a problem?

Greets
Marcus
Comment 5 Ruslan Kabatsayev 2011-08-08 18:10:25 UTC
gtk-qt-engine and oxygen-gtk are absolutely unrelated projects.
Comment 6 Marcus 2011-08-08 18:12:46 UTC
In general, yes. But the .gtkrc file is written by the gtk-qt-engine and looks like this:

# This file was written by KDE
# You can edit it in the KDE control center, under "GTK Styles and Fonts"

include "/usr/share/themes/oxygen-gtk/gtk-2.0/gtkrc"

style "user-font"
{
        font_name="DejaVu Sans"
}

gtk-theme-name="oxygen-gtk"
gtk-font-name="DejaVu Sans 9"
Comment 7 Marcus 2011-08-08 18:17:11 UTC
Created attachment 62670 [details]
another screenshot showing some more crippled elements

I have added another screenshot, showing some more crippled elements in Thunderbird/Icedove. Please note the pull down menus which are cut of at the left. Also the top border of the inner frame is not shown.
Comment 8 Hugo Pereira Da Costa 2011-08-08 19:14:00 UTC
Mmm. Maybe so called icedove (of which I know nothing) is simply not tagged as a mozilla app (and obviously should). That would explain.
Could you compile oxygen in debug mode (cmake -OXYGEN__DEBUG=1) and post the output of running the app here (as attachment)
Thx
Comment 9 Marcus 2011-08-08 19:47:34 UTC
Created attachment 62679 [details]
debug during start of iceweasel/thunderbird
Comment 10 Hugo Pereira Da Costa 2011-08-09 08:14:15 UTC
Git commit f52c1d553c17083dd4a7641a92ccc0b93ca4c840 by Hugo Pereira Da Costa.
Committed on 09/08/2011 at 09:48.
Pushed by hpereiradacosta into branch '1.1'.

added iceweasel, icecat, icedove, etc. as Mozilla applications.
CCBUG: 278348

M  +2    -2    src/oxygenapplicationname.cpp

http://commits.kde.org/oxygen-gtk/f52c1d553c17083dd4a7641a92ccc0b93ca4c840
Comment 11 Hugo Pereira Da Costa 2011-08-09 08:14:15 UTC
Git commit a10eca2e1ac0cde23570900e09de5e3773d696ab by Hugo Pereira Da Costa.
Committed on 09/08/2011 at 10:07.
Pushed by hpereiradacosta into branch '1.1'.

Use single tag (isXul) for all known XUL applications, adding icedove and company to the list.
CCBUG: 278348

M  +3    -10   src/oxygenapplicationname.h
M  +1    -1    src/oxygenshadowhelper.cpp
M  +1    -1    src/animations/oxygenanimationengine.h
M  +5    -5    src/oxygenstyle.cpp
M  +2    -2    src/oxygentaboptions.h
M  +31   -12   src/oxygenapplicationname.cpp
M  +19   -19   src/oxygenstylewrapper.cpp

http://commits.kde.org/oxygen-gtk/a10eca2e1ac0cde23570900e09de5e3773d696ab
Comment 12 Hugo Pereira Da Costa 2011-08-09 08:17:45 UTC
As expected, icedove is the application name, was not tagged by us as an XUL application, and therefore experienced the issues you encounter 
(due to Mozilla's buggy usage of gtk there is a lot of "exceptions" needed in our code to make oxygen-gtk works with it. Since additionally Mozilla does not provide an easy way to identify itself to the toolkit, we have to rely on the application name only to trigger this exception. This behavior is quite unacceptable, in fact, but there's not much we can do about it, unfortunately).

Anyway. Commits from comment #10 and #11 should fix the issue.
I also added iceweasel and icecat as other XUL applications.

Please confirm that all (well almost all) is good and close the bug if yes.

Cheers,

Hugo
Comment 13 Hugo Pereira Da Costa 2011-08-09 08:18:12 UTC
Side note: fixes have been committed to both master and 1.1 branches.
Comment 14 Ruslan Kabatsayev 2011-09-13 22:22:59 UTC
I suppose silence means it's fixed.