Bug 270919 - "Apply" button in Settings never grays out
Summary: "Apply" button in Settings never grays out
Status: ASSIGNED
Alias: None
Product: kgpg
Classification: Applications
Component: general (show other bugs)
Version: 2.6.x
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Rolf Eike Beer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-14 07:37 UTC by Robert Simmons
Modified: 2023-11-24 21:49 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Simmons 2011-04-14 07:37:01 UTC
Version:           1.0 (using KDE 4.6.2) 
OS:                Linux

In KGpg in Settings >> Configure KGpg... The "Apply" button is always available to press.  Even if you have not made any configuration changes it can still be pressed.  And if you press it, it does not gray out, it remains pressable.

Reproducible: Always

Steps to Reproduce:
Open KGpg
In the Settings menu select "Configure KGpg..."
Click the "Apply" button
or alternatively:
make a change to the config
Click the "Apply" button

Actual Results:  
Apply button is still pressable no matter what.

Expected Results:  
When the Settings window opens, Apply should be grayed out.  If you change something, it becomes available.  Then if you want to apply the changes you made, you can press it, and after that it grays out.

OS: Linux (i686) release 2.6.35-28-generic
Compiler: cc
I'm using Kubuntu 10.10 with KDE 4.6.2

The version of KGpg is 2.5.0
Comment 1 Burkhard Lück 2011-04-15 08:27:21 UTC
Confirmed in 4.6.2 (kubuntu 10.10) and master compiled from sources
Comment 2 Rolf Eike Beer 2011-04-18 07:58:18 UTC
SVN commit 1228398 by dakon:

use proper method visibility

Please test and see if this makes it any better. For me (openSUSE 11.3,
KDE 4.6.2) it is working fine even without that change.

CCBUG:270919

 M  +5 -4      kgpgoptions.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1228398
Comment 3 Burkhard Lück 2011-05-06 08:47:27 UTC
Tested with kgpgoptions.h r1228400 in trunk.
The Apply button is still always enabled.
Comment 4 Rolf Eike Beer 2011-05-06 16:27:36 UTC
Can you please add a kDebug() into that hasChanged() implementation and check if it is called at all? Please run KGpg from a terminal and send the complete output.
Comment 5 Burkhard Lück 2011-05-09 22:48:36 UTC
Added kDebug(); at the beginning of kgpgOptions::hasChanged(), it is called everytime I press the Apply button.

I have added a enableButtonApply(false); at the end of kgpgOptions::kgpgOptions in kgpg/kgpgoptions.cpp. Now the behaviour of the Apply button is correct for all options exceot the "The following widgets are managed manually." in kgpg/kgpgoptions.cpp.
Comment 6 Rolf Eike Beer 2011-05-31 19:11:57 UTC
Do those manually managed items work if you revert your change? For me it looks a bit as if the enable-thing somehow works reverted for you. Has *buntu somehow patched the kdelibs to get some special look&feel or something like that?
Comment 7 Robert Simmons 2011-05-31 19:16:39 UTC
I can open a bug in ubuntu to track this in case the problem is a patch that ubuntu applied.
Comment 8 Rolf Eike Beer 2011-05-31 19:23:20 UTC
Just so that noone get's me wrong: I don't know _if_ it's a *buntu bug/patch/change. I only see both of you having some of those distros and the problem while I'm using openSUSE and don't see anything. And I have absolutely no idea what's going on.
Comment 9 Robert Simmons 2011-05-31 19:29:14 UTC
Also, I've updated my system to Kubuntu 11.04 and KDE 4.6.3.  The bug still
exists (although KGpg has not changed version).

I've opened a bug report there, and referenced this bug report, perhaps that will help.  Maybe it is *buntu specific.
Comment 10 Robert Simmons 2011-05-31 19:39:11 UTC
One last thing: I've encountered this in KMail.  Perhaps it is related?
The report for that one is:
Bug 273896
Comment 11 Rolf Eike Beer 2011-05-31 19:59:40 UTC
Since those mainly works for me it definitely looks as if there is something wrong in the "lower levels". Please add the URL to the Ubuntu bug here.
Comment 12 Robert Simmons 2011-05-31 20:15:26 UTC
https://bugs.launchpad.net/kdeutils/+bug/790801
Comment 13 Burkhard Lück 2011-05-31 20:56:32 UTC
(In reply to comment #8)
> I only see both of you having some of those distros 

No, as i said in comment #1 and #3 also master compiled from sources
Comment 14 Burkhard Lück 2011-06-18 12:38:21 UTC
Checked again with a openSUSE 11.4 kde 4.6.0 in a virtual machine, the "Apply" button is always enabled, and never is greyed out even if I press it.
Comment 15 Burkhard Lück 2011-06-24 18:49:01 UTC
Sorry did not check this issue thorougly enough:
Running kgpg for the first time (no kgpgrc file, skip key generation in assistant) on openSUSE 11.4 kde 4.6.0 in the virtual machine the apply button is always enabled.
But once the Apply or OK button in the settings dialog is pressed - with or without a change - the Apply button behaves as expected, really strange.

@ Eike:
This is reproducable here, I just have to rm kgpgrc. Please mv your kgpgrc and you should be able to reproduce that as well.
Comment 16 Rolf Eike Beer 2011-12-17 15:33:39 UTC
What's the current state of this?
Comment 17 Tristan Miller 2014-05-18 19:09:31 UTC
Still reproducible for me with KGpg 2.12.1 (KDE 4.13.1 on openSUSE 13.1).
Comment 18 Tristan Miller 2016-09-17 14:28:23 UTC
Still reproducible for me with KGpg 2.17.0 (KDE 4.14.18 on openSUSE 42.1).
Comment 19 Burkhard Lück 2016-09-17 14:48:04 UTC
KGpg 2.17.40 4.14.16 in a VM Neon with Applications 16.08.1
not reproducible for me
Comment 20 Jack 2023-11-24 21:49:28 UTC
Is this still a problem?  I don't see it with version 23.08.3 on Gentoo Linux.