Bug 249139 - Xsession could/should load /etc/X11/Xresources
Summary: Xsession could/should load /etc/X11/Xresources
Status: RESOLVED FIXED
Alias: None
Product: kdm
Classification: Miscellaneous
Component: general (show other bugs)
Version: unspecified
Platform: openSUSE Linux
: NOR wishlist
Target Milestone: ---
Assignee: kdm bugs tracker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-26 19:17 UTC by Christian Trippe
Modified: 2011-05-11 08:57 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 4.6.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Trippe 2010-08-26 19:17:35 UTC
Version:           0.1 (using KDE 4.5.0) 
OS:                Linux

kdm does not use/ignores /etc/X11/Xresources This can cause e.g. xfig do be displayed in a wrong way. (see https://bugzilla.novell.com/show_bug.cgi?id=504624 )



Reproducible: Always

Steps to Reproduce:
To prove the above do:
xrdb -query | grep customization


Actual Results:  
no output

Expected Results:  
*customization: -color

as this is present in /etc/X11/Xresources

OS: Linux (i686) release 2.6.34-12-default
Compiler: gcc
Comment 1 Oswald Buddenhagen 2010-08-26 19:24:01 UTC
customizing Xsession to do more than the bare minimum is up to the distributors, so i'm tempted to simply reject the request. otoh, we try rather hard to load ~/.profile and co.
Comment 2 Oswald Buddenhagen 2010-09-11 21:57:09 UTC
SVN commit 1174288 by ossi:

load system and user Xresources in Xsession

FEATURE: 249139

 M  +5 -0      genkdmconf.c  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1174288
Comment 3 Ahmad Samir 2011-05-11 06:24:31 UTC
Hi.

The commit fixing this report doesn't look right:
"for i in /etc/X11/Xresources/*; do\n"
"  [ -f $i ] && xrdb -merge $i\n"
"done\n"

/etc/X11/Xresources isn't a directory, it's a file in fact; this is the case in Mageia, Mandriva and Fedora (and looking at the novell bug linked in the bug description, I think it's a file in Suse too). So it should just be:
[ -f $i ] && xrdb -merge /etc/X11/Xresources

IIUC.
Comment 4 Oswald Buddenhagen 2011-05-11 08:57:10 UTC
Git commit 0197011030d6e8a6fba95325a6ca6da30421b2b6 by Oswald Buddenhagen.
Committed on 11/05/2011 at 08:35.
Pushed by ossi into branch 'KDE/4.6'.

apparently, /etc/X11/Xresources can be a file, too

CCBUG: 249139
FIXED-IN: 4.6.4
(cherry picked from commit 36516393320760bbcb0dfd867cdd635e935fdb38)

M  +7    -3    kdm/kfrontend/genkdmconf.c     

http://commits.kde.org/kde-workspace/0197011030d6e8a6fba95325a6ca6da30421b2b6