Did you do something in the Lyrics applet?

I don't think I even added the lyrics applet, let alone use it

(In reply to comment #2)
> I don't think I even added the lyrics applet, let alone use it

You don't have to add it, it is one of the three default applets.

*** Bug 245828 has been marked as a duplicate of this bug. ***

The LyricsApplet seems to be deleted before init() is called.
m_proxy->setWidget( 0 ) in ~LyricsApplet() crashes as m_proxy==0.

Bug #246340 is similiar, just with the Albums applet.

*** Bug 246340 has been marked as a duplicate of this bug. ***

As mentioned in the duplicate, this is also triggered by a destructor error of the Albums applet.

It also crashes with only the wikipedia plugin and the current track plugins enabled, but it doesn't crash with the current track plugin alone.

You all seem to use KDE RC3 or higher. I can't reproduce this here with the Lyrics applet.

(In reply to comment #8)
> It also crashes with only the wikipedia plugin and the current track plugins
> enabled, but it doesn't crash with the current track plugin alone.

Are you sure about the Wikipedia applet?
If so, please post a backtrace.

*** Bug 246771 has been marked as a duplicate of this bug. ***

(In reply to comment #10)
> (In reply to comment #8)
> > It also crashes with only the wikipedia plugin and the current track plugins
> > enabled, but it doesn't crash with the current track plugin alone.
> 
> Are you sure about the Wikipedia applet?
> If so, please post a backtrace.

Actually, I enabled the wikipedia applet and Amarok still exits fine, so it may not be related.

Regards,

-- Shlomi Fish

Created attachment 49825 [details]
Patch to fix destructors of all applets

This patch fixes all applets so they don't crash when they are deleted before init() is called.

However there is probably another underlying issue that causes this behaviour in the first place.

*** Bug 246956 has been marked as a duplicate of this bug. ***

Hi,

(In reply to comment #13)
> Created an attachment (id=49825) [details]
> Patch to fix destructors of all applets
> 
> This patch fixes all applets so they don't crash when they are deleted before
> init() is called.
> 
> However there is probably another underlying issue that causes this behaviour
> in the first place.

Doing those "!= 0" checks shouldn't be necessary.
See my comment here (I also attached a patch there): https://bugs.kde.org/show_bug.cgi?id=246340#c12

Regards,
Martin

Created attachment 49914 [details]
Patch to fix destructors of all applets (v2)

(In reply to comment #15)
> Doing those "!= 0" checks shouldn't be necessary.
> See my comment here (I also attached a patch there):
> https://bugs.kde.org/show_bug.cgi?id=246340#c12

Albums applet: I agree with your patch.

LyricsApplet and SongkickApplet:
I think removing the setWidget(0) calls is dangerous.

With your patch applied ~SongkickApplet looks like this:
delete m_songkickProxy; // deletes m_songkickProxy and m_songkick (as m_songkickProxy->widget()==m_songkick)
m_songkickProxy = 0;
delete m_songkick; // double delete!

~SongkickApplet should be reducable to just:
delete m_songkickProxy;

For ~LyricsApplet the setWidget(0) call is necessary as the embedded widget can be m_lyrics or m_suggested.

Attaching an updated patch with these changes.

(In reply to comment #16)
> ...Attaching an updated patch with these changes.
You are right with your comments regarding my patch - good work :)

Your new patch looks fine to me.
Let's wait until someone commits your patch

*** Bug 247069 has been marked as a duplicate of this bug. ***

commit b5c9c8ea3f0f63ac6119006ea20894752a799975
Author: Leo Franchi <lfranchi@kde.org>
Date:   Sun Aug 8 12:30:02 2010 -0400

    Various fixes to deleting QGraphicsProxyWidgets
    Don't call disconnect source on dataengine in destructor of applet as engine may already have been deleted, and that will force it to be re-loaded and crash.
    
    Thanks to Martin Blumenstingl and Felix Geyer for the patch!
    
    BUG: 245513

diff --git a/ChangeLog b/ChangeLog
index 5234be9..7a856ec 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -42,6 +42,8 @@ VERSION 2.3.2-Beta 1
       Patch by Richard Longland <rlongland@hotmail.com>.
 
   BUGFIXES:
+    * Fix crash on exit with newer KDE versions. Patch by Martin Blumenstingl and Felix
+      Geyer. (BR 245513)
     * Fixed playlist bottom toolbar getting to tall when using "Text only"
       button style. (BR 228390)
     * Fixed Amarok layout saving when minized to tray. (BR 244583)
diff --git a/src/context/applets/albums/Albums.cpp b/src/context/applets/albums/Albums.cpp
index 6da2411..3eceeee 100644
--- a/src/context/applets/albums/Albums.cpp
+++ b/src/context/applets/albums/Albums.cpp
@@ -45,13 +45,14 @@ Albums::Albums( QObject* parent, const QVariantList& args )
     : Context::Applet( parent, args )
     , m_albumWidth( 50 )
     , m_recentCount( Amarok::config("Albums Applet").readEntry("RecentlyAdded", 5) )
+    , m_albumsView( 0 )
 {
     setHasConfigurationInterface( true );
 }
 
 Albums::~Albums()
 {
-    delete m_albumsView->widget();
+    delete m_albumsView;
 }
 
 void Albums::init()
diff --git a/src/context/applets/currenttrack/CurrentTrack.cpp b/src/context/applets/currenttrack/CurrentTrack.cpp
index 44ac544..aba20ef 100644
--- a/src/context/applets/currenttrack/CurrentTrack.cpp
+++ b/src/context/applets/currenttrack/CurrentTrack.cpp
@@ -64,7 +64,6 @@ CurrentTrack::CurrentTrack( QObject* parent, const QVariantList& args )
 
 CurrentTrack::~CurrentTrack()
 {
-    dataEngine( "amarok-current" )->disconnectSource( "current", this );
     delete m_tabBar;
 }
 
diff --git a/src/context/applets/lyrics/LyricsApplet.cpp b/src/context/applets/lyrics/LyricsApplet.cpp
index c1944e4..f1a4110 100644
--- a/src/context/applets/lyrics/LyricsApplet.cpp
+++ b/src/context/applets/lyrics/LyricsApplet.cpp
@@ -64,8 +64,11 @@ LyricsApplet::LyricsApplet( QObject* parent, const QVariantList& args )
 
 LyricsApplet::~ LyricsApplet()
 {
-    m_proxy->setWidget( 0 );
-    delete m_proxy;
+    if( m_proxy )
+    {
+        m_proxy->setWidget( 0 );
+        delete m_proxy;
+    }
     delete m_lyrics;
     delete m_suggested;
 }
diff --git a/src/context/applets/similarartists/SimilarArtistsApplet.cpp b/src/context/applets/similarartists/SimilarArtistsApplet.cpp
index 40ea5e3..631af45 100644
--- a/src/context/applets/similarartists/SimilarArtistsApplet.cpp
+++ b/src/context/applets/similarartists/SimilarArtistsApplet.cpp
@@ -59,6 +59,8 @@ SimilarArtistsApplet::SimilarArtistsApplet( QObject *parent, const QVariantList&
         , m_headerAspectRatio( 0.0 )
         , m_headerLabel( 0 )
         , m_settingsIcon( 0 )
+        , m_layout( 0 )
+        , m_scroll( 0 )
 {
     setHasConfigurationInterface( true );
     setBackgroundHints( Plasma::Applet::NoBackground );
diff --git a/src/context/applets/songkick/SongkickApplet.cpp b/src/context/applets/songkick/SongkickApplet.cpp
index 583c48b..cacdb27 100644
--- a/src/context/applets/songkick/SongkickApplet.cpp
+++ b/src/context/applets/songkick/SongkickApplet.cpp
@@ -42,6 +42,7 @@ SongkickApplet::SongkickApplet( QObject* parent, const QVariantList& args )
     , m_titleLabel( 0 )
     , m_reloadIcon( 0 )
     , m_songkick( 0 )
+    , m_songkickProxy( 0 )
 {
     setHasConfigurationInterface( false );
     setBackgroundHints( Plasma::Applet::NoBackground );
@@ -49,10 +50,7 @@ SongkickApplet::SongkickApplet( QObject* parent, const QVariantList& args )
 
 SongkickApplet::~ SongkickApplet()
 {
-    m_songkickProxy->setWidget( 0 );
     delete m_songkickProxy;
-    m_songkickProxy = 0;
-    delete m_songkick;
 }
 
 void SongkickApplet::init()
diff --git a/src/context/applets/videoclip/VideoclipApplet.cpp b/src/context/applets/videoclip/VideoclipApplet.cpp
index e1ea132..fe7b652 100644
--- a/src/context/applets/videoclip/VideoclipApplet.cpp
+++ b/src/context/applets/videoclip/VideoclipApplet.cpp
@@ -73,6 +73,7 @@ VideoclipApplet::VideoclipApplet( QObject* parent, const QVariantList& args )
         , Engine::EngineObserver( The::engineController() )
         , m_settingsIcon( 0 )
         , m_youtubeHQ( false )
+        , m_videoWidget( 0 )
 {
     DEBUG_BLOCK
     setHasConfigurationInterface( true );

*** Bug 247237 has been marked as a duplicate of this bug. ***

*** Bug 247278 has been marked as a duplicate of this bug. ***

*** Bug 247345 has been marked as a duplicate of this bug. ***

*** Bug 247385 has been marked as a duplicate of this bug. ***

*** Bug 247494 has been marked as a duplicate of this bug. ***

*** Bug 247540 has been marked as a duplicate of this bug. ***

Created attachment 50092 [details]
New crash information added by DrKonqi

amarok (2.3.1) on KDE Platform 4.5.00 (KDE 4.5.0) using Qt 4.7.0

- What I was doing when the application crashed:
I was just starting amarok

- Unusual behavior I noticed:
not sure if the patch in this report has been integrated in kde 4.5.0  but for me it crashes at that level.
- Custom settings of the application:
mysql database

-- Backtrace (Reduced):
#6  QGraphicsProxyWidget::setWidget (this=0x0, widget=0x0) at graphicsview/qgraphicsproxywidget.cpp:593
#7  0x00007f3a37746132 in ~LyricsApplet (this=0x164bc80, __in_chrg=<value optimized out>) at ../../../../../src/context/applets/lyrics/LyricsApplet.cpp:67
#8  0x00007f3a62d938a8 in QObject::event (this=0x164bc80, e=0x0) at kernel/qobject.cpp:1202
#9  0x00007f3a63dc171b in QGraphicsWidget::event (this=0x164bc80, event=0x1684040) at graphicsview/qgraphicswidget.cpp:1404
#10 0x00007f3a63750cdc in QApplicationPrivate::notify_helper (this=0x897bf0, receiver=0x164bc80, e=0x1684040) at kernel/qapplication.cpp:4389

@p92: it is triggered by KDE 4.5, but already fixed in the upcoming Amarok 2.3.2. As a workaround until then, please disable the Lyrics Applet. Beware, the Similar Artist and Album applets can cause the same problem.

*** Bug 247888 has been marked as a duplicate of this bug. ***

*** Bug 247843 has been marked as a duplicate of this bug. ***

*** Bug 247932 has been marked as a duplicate of this bug. ***

Is there going to be a minor bugfix release? If not, is there a daily build somewhere?

(In reply to comment #31)
> Is there going to be a minor bugfix release? If not, is there a daily build
> somewhere?

We do not backport fixes, but Amarok 2.3.2 beta 1 is to be released next week.

*** Bug 248041 has been marked as a duplicate of this bug. ***

*** Bug 248048 has been marked as a duplicate of this bug. ***

*** Bug 248066 has been marked as a duplicate of this bug. ***

*** Bug 248098 has been marked as a duplicate of this bug. ***

*** Bug 248168 has been marked as a duplicate of this bug. ***

*** Bug 248181 has been marked as a duplicate of this bug. ***

Created attachment 50703 [details]
New crash information added by DrKonqi

amarok (2.3.1) on KDE Platform 4.5.00 (KDE 4.5.0) using Qt 4.7.0

- What I was doing when the application crashed:

Running KDE 4.5.00 on Kubuntu 10.04. Haven't been able to use Amarok in almost 1/2 a year, so first time I've launched it in forever... it crashed at launch. This bug appears to still be an issue, even on a fully updated and current system

-- Backtrace (Reduced):
#6  QGraphicsProxyWidget::setWidget (this=0x0, widget=0x0) at graphicsview/qgraphicsproxywidget.cpp:593
[...]
#8  0x00007f8770dd78a8 in QObject::event (this=0x2350810, e=0x0) at kernel/qobject.cpp:1202
#9  0x00007f8771e0571b in QGraphicsWidget::event (this=0x2350810, event=0x23540b0) at graphicsview/qgraphicswidget.cpp:1404
#10 0x00007f8771794cdc in QApplicationPrivate::notify_helper (this=0x13e9cd0, receiver=0x2350810, e=0x23540b0) at kernel/qapplication.cpp:4389
#11 0x00007f877179a7cd in QApplication::notify (this=0x7fff0522fba0, receiver=0x2350810, e=0x23540b0) at kernel/qapplication.cpp:4270

(In reply to comment #39)
> Created an attachment (id=50703) [details]
> New crash information added by DrKonqi
> 
> amarok (2.3.1) on KDE Platform 4.5.00 (KDE 4.5.0) using Qt 4.7.0
> 
> - What I was doing when the application crashed:
> 
> Running KDE 4.5.00 on Kubuntu 10.04. Haven't been able to use Amarok in almost
> 1/2 a year, so first time I've launched it in forever... it crashed at launch.
> This bug appears to still be an issue, even on a fully updated and current
> system

You can upgrade to Amarok 2.3.2 beta 1 (which contains the bugfix):
http://www.kubuntu.org/news/amarok-2.3.2-beta

*** Bug 248325 has been marked as a duplicate of this bug. ***

*** Bug 248349 has been marked as a duplicate of this bug. ***

*** Bug 248406 has been marked as a duplicate of this bug. ***

*** Bug 248429 has been marked as a duplicate of this bug. ***

*** Bug 248623 has been marked as a duplicate of this bug. ***

*** Bug 248630 has been marked as a duplicate of this bug. ***

*** Bug 248698 has been marked as a duplicate of this bug. ***

*** Bug 248702 has been marked as a duplicate of this bug. ***

*** Bug 248803 has been marked as a duplicate of this bug. ***

*** Bug 248812 has been marked as a duplicate of this bug. ***

*** Bug 248860 has been marked as a duplicate of this bug. ***

I was experiencing a similar bug on Mandriva 2007.0 and now on Mandriva 2010.0.  The latter uses Amarok 2.2.0.  I could keep Amarok running for up to 30 minutes, and then it would crash.  It would also sometimes start skipping portions of songs just before it would crash.  In order to look at the backtrace I installed 6 or 8 debug libraries, the ones containing symbols.  Now I've been running Amarok for 2 solid hours with no issues.  I wonder if this bug was confirmed fixed using the debug libraries, or the stripped libraries.  I'm not saying that this bug isn't fixed, just wondering about the libraries because of my own issue.
To debug that issue, I'll start removing those debug libraries one at a time to see if I can force the problem to occur once more.  Thanks for your time.

Kevin, this is about a version way ahead of 2.2.0, I hope you realize this. It is already solved in the upcoming 2.3.2

Created attachment 51026 [details]
New crash information added by DrKonqi

amarok (2.3.1) on KDE Platform 4.5.00 (KDE 4.5.0) using Qt 4.7.0

- What I was doing when the application crashed:

I just clicked on a .mp3 in Dolphin file to be played and Amarok did not started.

-- Backtrace (Reduced):
#6  QGraphicsProxyWidget::setWidget (this=0x0, widget=0x0) at graphicsview/qgraphicsproxywidget.cpp:593
#7  0x00007fd24fff1132 in ~LyricsApplet (this=0x2eeea60, __in_chrg=<value optimized out>) at ../../../../../src/context/applets/lyrics/LyricsApplet.cpp:67
#8  0x00007fd2813bc8a8 in QObject::event (this=0x2eeea60, e=0x0) at kernel/qobject.cpp:1202
#9  0x00007fd2823ea73b in QGraphicsWidget::event (this=0x2eeea60, event=0x2f84d50) at graphicsview/qgraphicswidget.cpp:1404
#10 0x00007fd281d79cdc in QApplicationPrivate::notify_helper (this=0x21afa50, receiver=0x2eeea60, e=0x2f84d50) at kernel/qapplication.cpp:4389

Created attachment 51041 [details]
New crash information added by DrKonqi

amarok (2.3.1) on KDE Platform 4.5.00 (KDE 4.5.0) using Qt 4.7.0

- What I was doing when the application crashed:

I was in kubuntu lucid with KDE 3.5.10 and Amarok 2.3.1 crashes after splashscreen and program never will execute. The only solution is open Amarok 1.4.
In same computer there be KDE 3.5.10 and KDE SC 4.5. In KDE SC 4.5 there's no problem.
I attached my information from amarok-dbg package in 2.3.1 version.

-- Backtrace (Reduced):
#6  QGraphicsProxyWidget::setWidget (this=0x0, widget=0x0) at graphicsview/qgraphicsproxywidget.cpp:593
#7  0x00007f6c5d88f132 in ~LyricsApplet (this=0x7f6c6c9d5c60, __in_chrg=<value optimized out>) at ../../../../../src/context/applets/lyrics/LyricsApplet.cpp:67
#8  0x00007f6c900018a8 in QObject::event (this=0x7f6c6c9d5c60, e=0x0) at kernel/qobject.cpp:1202
#9  0x00007f6c9102f73b in QGraphicsWidget::event (this=0x7f6c6c9d5c60, event=0x7f6c6ca08220) at graphicsview/qgraphicswidget.cpp:1404
#10 0x00007f6c909becdc in QApplicationPrivate::notify_helper (this=0xef5200, receiver=0x7f6c6c9d5c60, e=0x7f6c6ca08220) at kernel/qapplication.cpp:4389

*** Bug 249264 has been marked as a duplicate of this bug. ***

Please all, stop submitting backtraces, read that bug instead, it is fixed in a version ahead of yours. Also please read comment #27

Sorry, but my amarok version is 2.3.1 yet. When I finally install 2.3.2 version I confirm this fix.

Thanks to all team!

(In reply to comment #58)
> Sorry, but my amarok version is 2.3.1 yet. When I finally install 2.3.2 version
> I confirm this fix.

No need to confirm, it is already confirmed by those using the devel version :)

I will confirm this personally. No more annoying you, Bye!

Created attachment 51046 [details]
New crash information added by DrKonqi

amarok (2.3.1) on KDE Platform 4.5.00 (KDE 4.5.0) using Qt 4.6.3

- What I was doing when the application crashed:

Amarok crashed when I started up. Akregator and Kopete was starting up too, and did it fine. The last time I switch off my laptop Amarok crashed too.

-- Backtrace (Reduced):
#7  0xa366cad3 in SimilarArtistsApplet::~SimilarArtistsApplet() () from /usr/lib/kde4/amarok_context_applet_similarArtists.so
#8  0xa366cbe2 in SimilarArtistsApplet::~SimilarArtistsApplet() () from /usr/lib/kde4/amarok_context_applet_similarArtists.so
#9  0xb65033e5 in qDeleteInEventHandler(QObject*) () from /usr/lib/libQtCore.so.4
#10 0xb6504830 in QObject::event(QEvent*) () from /usr/lib/libQtCore.so.4
#11 0xb60fe804 in QGraphicsWidget::event(QEvent*) () from /usr/lib/libQtGui.so.4

The Subject/Title says "...crashed on quit", more people posting backtraces crashed on start-up

*** Bug 249406 has been marked as a duplicate of this bug. ***

*** Bug 249425 has been marked as a duplicate of this bug. ***

*** Bug 249550 has been marked as a duplicate of this bug. ***

*** Bug 249619 has been marked as a duplicate of this bug. ***

*** Bug 249715 has been marked as a duplicate of this bug. ***

*** Bug 249737 has been marked as a duplicate of this bug. ***

*** Bug 249813 has been marked as a duplicate of this bug. ***

*** Bug 249981 has been marked as a duplicate of this bug. ***

*** Bug 250199 has been marked as a duplicate of this bug. ***

*** Bug 250253 has been marked as a duplicate of this bug. ***

Created attachment 51339 [details]
New crash information added by DrKonqi

amarok (2.3-GIT) on KDE Platform 4.5.1 (KDE 4.5.1) using Qt 4.7.0

- What I was doing when the application crashed:
quitting amarok, always results in a crash.

-- Backtrace (Reduced):
#7  0x01cfe708 in QGraphicsProxyWidget::setWidget(QWidget*) () from /usr/lib/libQtGui.so.4
#8  0x07e48602 in ~LyricsApplet (this=0x90973a8, __in_chrg=<value optimized out>) at /sharedstuff/sources/amarok/src/context/applets/lyrics/LyricsApplet.cpp:67
#9  0x07b75dc5 in qDeleteInEventHandler(QObject*) () from /usr/lib/libQtCore.so.4
#10 0x07b77ae8 in QObject::event(QEvent*) () from /usr/lib/libQtCore.so.4
#11 0x01d429d4 in QGraphicsWidget::event(QEvent*) () from /usr/lib/libQtGui.so.4

*** Bug 250612 has been marked as a duplicate of this bug. ***

Created attachment 51498 [details]
New crash information added by DrKonqi

amarok (2.3.1) on KDE Platform 4.5.1 (KDE 4.5.1) using Qt 4.7.0

Using a collection compiled from a mounted network drive using cifs

-- Backtrace (Reduced):
#7  0xb687b708 in QGraphicsProxyWidget::setWidget (this=0x0, widget=0x0) at graphicsview/qgraphicsproxywidget.cpp:593
#8  0xa0211f62 in ~LyricsApplet (this=0xa04c598, __in_chrg=<value optimized out>) at ../../../../../src/context/applets/lyrics/LyricsApplet.cpp:67
#9  0xb5cc9dc5 in qDeleteInEventHandler (o=0x0) at kernel/qobject.cpp:3988
#10 0xb5ccbae8 in QObject::event (this=0xa04c598, e=0xa0219d14) at kernel/qobject.cpp:1202
#11 0xb68bf9d4 in QGraphicsWidget::event (this=0xa04c598, event=0xa082c20) at graphicsview/qgraphicswidget.cpp:1405

*** Bug 250700 has been marked as a duplicate of this bug. ***

*** Bug 250803 has been marked as a duplicate of this bug. ***

*** Bug 250995 has been marked as a duplicate of this bug. ***

*** Bug 251169 has been marked as a duplicate of this bug. ***

*** Bug 251184 has been marked as a duplicate of this bug. ***

*** Bug 251219 has been marked as a duplicate of this bug. ***

*** Bug 251595 has been marked as a duplicate of this bug. ***

*** Bug 253370 has been marked as a duplicate of this bug. ***

KDE Programms "crashes" sometimes if i quit them with the red cross on the upper right side - incluvive amarok. So thers no Prob, only that the bugzilla Prog pops up. Wahts up ?  ;D

Matthias Schuster Scharmer