Bug 242800 - I can create a hole (chess board) when changing the layer opacity and arithmetic
Summary: I can create a hole (chess board) when changing the layer opacity and arithmetic
Status: CLOSED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Tile manager (show other bugs)
Version: git master (please specify the git hash!)
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Dmitry Kazakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-25 17:30 UTC by Jaime Torres
Modified: 2010-09-27 17:33 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
the chess board (465.11 KB, image/png)
2010-09-25 23:31 UTC, Jaime Torres
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jaime Torres 2010-06-25 17:30:18 UTC
Version:           svn trunk (using Devel) 
OS:                Linux

I open a jpeg image (~6Mb), then in the layers toolbox, I change the opacity to 99 and the arithmetic to Add. I see a chess board. If I change the opacity to 100 the image comes back. If I'm fast enough to change the arithmetic when the image is being repainted, a tile of the chess board keeps. And after that, changing the opacity again does not restores the tile. Even it is shown in this way in the layers thumbail.

Reproducible: Always

Steps to Reproduce:
The trick is to change the arithmetic when the image is being repainted. In a "slow" machine is easier.
Comment 1 Halla Rempt 2010-08-15 16:32:34 UTC
BUGDAY
Comment 2 Michael Leupold 2010-08-22 18:57:36 UTC
Can't recreate the original bug. After showing the checkers first, the image is repainted after a short delay. I do however get crashes or hanging X sometimes (which can be fixed by killing Krita from the terminal).
Comment 3 Dmitry Kazakov 2010-09-25 17:01:21 UTC
I can't reproduce the original bug. Can you?
Comment 4 Jaime Torres 2010-09-25 23:28:46 UTC
I'm not able to do it changing the layer opacity and arithmetic. But if you change in the original bug title "and" by "or", it is still there (trunk from 5 hours ago).

The attached capture has been done changing the layer opacity several times while it was still redrawing the photo. Fortunately, the saved image is good (without the chess boards).
Comment 5 Jaime Torres 2010-09-25 23:31:08 UTC
Created attachment 51992 [details]
the chess board
Comment 6 Dmitry Kazakov 2010-09-26 06:55:50 UTC
ok, got it =)
Comment 7 Dmitry Kazakov 2010-09-26 09:26:05 UTC
SVN commit 1179725 by dkazakov:

Fixed a race condition in KisAsyncMerger

The original of a group layer can change due to oblige child
mechanism, so we must cache this value to get stable and guaranteed
result.

BUG:242800


 M  +24 -5     kis_async_merger.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1179725
Comment 8 Jaime Torres 2010-09-26 19:44:03 UTC
Just to say: Good work. Thank you. It works now. 
Krita is shining brighter than ever.