Bug 237857 - some tooltip strings are long, but have no line breaks
Summary: some tooltip strings are long, but have no line breaks
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: Collections/Local (show other bugs)
Version: 2.3.0.90
Platform: unspecified Linux
: NOR normal
Target Milestone: 2.3.2
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-16 19:33 UTC by Alexander Potashev
Modified: 2012-08-19 16:52 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 2.3.2


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Potashev 2010-05-16 19:33:08 UTC
Version:           2.3.0.90 (using 4.4.3 (KDE 4.4.3), Gentoo)
Compiler:          x86_64-pc-linux-gnu-gcc
OS:                Linux (x86_64) release 2.6.32

For example, this tooptip is long, but has no line breaks (\n):

If checked, replace characters that are incompatible with MS-DOS/VFAT file 
systems with underscores. Incompatible characters include |?*<":>+[] and 
unicode control characters. Most people can leave this option enabled as it 
ensures copying to media devices will function correctly.
Comment 1 Casey Link 2010-05-29 22:10:47 UTC
Thanks for the report!

Fix coming soon.
Comment 2 Casey Link 2010-05-30 06:40:25 UTC
commit a3fd1f4c7b16a318d1c0d02206ce077061f7382d
Author: Casey Link <unnamedrambler@gmail.com>
Date:   Sat May 29 15:09:21 2010 -0500

    Cleaned up some tooltips/what's this strings in the Organize dialog to make it easier to read and, hopefully, understand.
    BUG: 237857

diff --git a/ChangeLog b/ChangeLog
index 4534e99..69fa47c 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -25,6 +25,8 @@ VERSION 2.3.2-Beta 1
       Patch by Richard Longland <rlongland@hotmail.com>.
 
   BUGFIXES:
+    * Cleaned up some tooltips/what's this strings in the Organize dialog
+      to make it easier to read and, hopefully, understand. (BR 237857)
     * Fixed organize dialog's handling of the year tag. If there is no year
       then the %year token should be an empty string.(BR 237834)
     * The "Ignore 'The'" option in the organize files dialog is now case
diff --git a/src/dialogs/OrganizeCollectionDialogBase.ui b/src/dialogs/OrganizeCollectionDialogBase.ui
index c3aea70..9cf1c57 100644
--- a/src/dialogs/OrganizeCollectionDialogBase.ui
+++ b/src/dialogs/OrganizeCollectionDialogBase.ui
@@ -57,7 +57,10 @@
         </sizepolicy>
        </property>
        <property name="toolTip">
-        <string/>
+        <string>The collection folder to which the files will be transferred.</string>
+       </property>
+       <property name="whatsThis">
+        <string>The collection folder to which the files will be transferred.</string>
        </property>
       </widget>
      </item>
@@ -98,10 +101,24 @@
       <item>
        <widget class="QCheckBox" name="asciiCheck">
         <property name="toolTip">
-         <string>If checked all non-ASCII characters will be replaced with underscores. Do not check this option if you have non-English characters in your tags. Most people can leave this option unchecked.</string>
+         <string>&lt;!DOCTYPE HTML PUBLIC &quot;-//W3C//DTD HTML 4.0//EN&quot; &quot;http://www.w3.org/TR/REC-html40/strict.dtd&quot;&gt;
+&lt;html&gt;&lt;head&gt;&lt;meta name=&quot;qrichtext&quot; content=&quot;1&quot; /&gt;&lt;style type=&quot;text/css&quot;&gt;
+p, li { white-space: pre-wrap; }
+&lt;/style&gt;&lt;/head&gt;&lt;body style=&quot; font-family:'Sans Serif'; font-size:9pt; font-weight:400; font-style:normal;&quot;&gt;
+&lt;p style=&quot; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;&quot;&gt;If checked, all non-ASCII characters will be replaced with underscores.&lt;span style=&quot; font-weight:600;&quot;&gt; &lt;/span&gt;&lt;/p&gt;
+&lt;p style=&quot;-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; font-weight:600;&quot;&gt;&lt;/p&gt;
+&lt;p style=&quot; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;&quot;&gt;&lt;span style=&quot; font-weight:600;&quot;&gt;Do not check this option if you have non-English characters in your tags. &lt;/span&gt;&lt;/p&gt;
+&lt;p style=&quot;-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;&quot;&gt;&lt;/p&gt;
+&lt;p style=&quot; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;&quot;&gt;Most people can leave this option unchecked.&lt;/p&gt;&lt;/body&gt;&lt;/html&gt;</string>
         </property>
         <property name="whatsThis">
-         <string>If checked all non-ASCII characters will be replaced with underscores. Do not check this option if you have non-English characters in your tags. Most people can leave this option unchecked.</string>
+         <string>&lt;!DOCTYPE HTML PUBLIC &quot;-//W3C//DTD HTML 4.0//EN&quot; &quot;http://www.w3.org/TR/REC-html40/strict.dtd&quot;&gt;
+&lt;html&gt;&lt;head&gt;&lt;meta name=&quot;qrichtext&quot; content=&quot;1&quot; /&gt;&lt;style type=&quot;text/css&quot;&gt;
+p, li { white-space: pre-wrap; }
+&lt;/style&gt;&lt;/head&gt;&lt;body style=&quot; font-family:'Sans Serif'; font-size:9pt; font-weight:400; font-style:normal;&quot;&gt;
+&lt;p style=&quot; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;&quot;&gt;If checked, all non-ASCII characters will be replaced with underscores.&lt;span style=&quot; font-weight:600;&quot;&gt; Do not check this option if you have non-English characters in your tags. &lt;/span&gt;&lt;/p&gt;
+&lt;p style=&quot;-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;&quot;&gt;&lt;/p&gt;
+&lt;p style=&quot; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;&quot;&gt;Most people can leave this option &lt;span style=&quot; font-style:italic;&quot;&gt;unchecked.&lt;/span&gt;&lt;/p&gt;&lt;/body&gt;&lt;/html&gt;</string>
         </property>
         <property name="text">
          <string>Restrict to &amp;ASCII</string>
@@ -111,10 +128,14 @@
       <item>
        <widget class="QCheckBox" name="vfatCheck">
         <property name="toolTip">
-         <string>If checked, replace characters that are incompatible with MS-DOS/VFAT file systems with underscores. Incompatible characters include |?*&lt;&quot;:&gt;+[] and unicode control characters. Most people can leave this option enabled as it ensures copying to media devices will function correctly.</string>
+         <string>Replace characters that are incompatible with MS-DOS/VFAT file systems with underscores. 
+
+Most people can leave this option enabled.</string>
         </property>
         <property name="whatsThis">
-         <string>If checked, replace characters that are incompatible with MS-DOS/VFAT file systems with underscores. Incompatible characters include |?*&lt;&quot;:&gt;+[] and unicode control characters. Most people can leave this option enabled as it ensures copying to media devices will function correctly.</string>
+         <string>If checked, replace characters that are incompatible with MS-DOS/VFAT file systems with underscores. Incompatible characters include |?*&lt;&quot;:&gt;+[] and unicode control characters. 
+
+Most people can leave this option enabled as it ensures copying to media devices will function correctly.</string>
         </property>
         <property name="text">
          <string>&amp;VFAT safe names</string>
@@ -192,6 +213,9 @@
         <attribute name="verticalHeaderVisible">
          <bool>false</bool>
         </attribute>
+        <attribute name="verticalHeaderVisible">
+         <bool>false</bool>
+        </attribute>
         <column>
          <property name="text">
           <string>Original</string>
@@ -257,7 +281,11 @@
            <string>If checked, overwrite files of the same name without asking.</string>
           </property>
           <property name="whatsThis">
-           <string>Check this to overwrite files of the same name automatically. (Warning: Overwriting is not undoable)</string>
+           <string>&lt;!DOCTYPE HTML PUBLIC &quot;-//W3C//DTD HTML 4.0//EN&quot; &quot;http://www.w3.org/TR/REC-html40/strict.dtd&quot;&gt;
+&lt;html&gt;&lt;head&gt;&lt;meta name=&quot;qrichtext&quot; content=&quot;1&quot; /&gt;&lt;style type=&quot;text/css&quot;&gt;
+p, li { white-space: pre-wrap; }
+&lt;/style&gt;&lt;/head&gt;&lt;body style=&quot; font-family:'Sans Serif'; font-size:9pt; font-weight:400; font-style:normal;&quot;&gt;
+&lt;p style=&quot; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;&quot;&gt;Check this to overwrite files of the same name automatically. &lt;span style=&quot; font-style:italic;&quot;&gt;(Warning: Overwriting is not undoable)&lt;/span&gt;&lt;/p&gt;&lt;/body&gt;&lt;/html&gt;</string>
           </property>
           <property name="text">
            <string>Overwrite &amp;Destination</string>