Bug 235957 - Edit Track Details -> Labels needs more space
Summary: Edit Track Details -> Labels needs more space
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: Metadata Editing and Reading (show other bugs)
Version: 2.3-GIT
Platform: unspecified Linux
: NOR normal
Target Milestone: 2.3.2
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-01 23:21 UTC by Johannes Obermayr
Modified: 2010-08-13 15:18 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 2.3.1


Attachments
screenshot (40.81 KB, image/png)
2010-05-01 23:23 UTC, Johannes Obermayr
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Johannes Obermayr 2010-05-01 23:21:46 UTC
Version:           2.3-GIT (using 4.4.74 (KDE 4.4.74 (KDE 4.5 >= 20100428)) "release 3", KDE:KDE4:UNSTABLE:Desktop / openSUSE_11.2)
Compiler:          gcc
OS:                Linux (i686) release 2.6.34-rc5-22-pae

1. Right click on a track in playlist
2. Choose "Edit Track Details"
3. Choose in upcoming dialog "Labels" tab

There is a TextLabel called "Label:". In German there should be "Schlagwort" but it is only "Schla".

Located is it in: dialogs/TagDialogBase.ui:739

It was reported on mailing list back in Feb.
Comment 1 Johannes Obermayr 2010-05-01 23:23:17 UTC
Created attachment 43155 [details]
screenshot

Bavarian and Austrian guys know why this screenshot is funny related to the bug...
Comment 2 Soren Harward 2010-05-10 03:41:08 UTC
commit 302617808e6e30e7668c821bdc3a8de4d8f3015c
Author: Soren Harward <stharward@gmail.com>
Date:   Sun May 9 21:35:13 2010 -0400

    Better SizePolicy for label widget in TagDialog
    
    This prevents the associated "Label:" label from being truncated for
    translations of "Label:".
    
    BUG: 235957

diff --git a/ChangeLog b/ChangeLog
index 1ca2a1f..5d5f7a2 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -7,6 +7,7 @@ VERSION 2.3.1
   CHANGES:
 
   BUGFIXES:
+    * Don't truncate the "Label:" label in the TagDialog. (BR 235957)
     * Display extended characters properly in names of Last.fm streams.
       (BR 222930)
     * Cover fetcher: prevent automatic fetcher from setting album's cover if
diff --git a/src/dialogs/TagDialogBase.ui b/src/dialogs/TagDialogBase.ui
index 7b4b47f..ff3a3db 100644
--- a/src/dialogs/TagDialogBase.ui
+++ b/src/dialogs/TagDialogBase.ui
@@ -745,6 +745,12 @@
              </item>
              <item>
               <widget class="KComboBox" name="kComboBox_label">
+               <property name="sizePolicy">
+                <sizepolicy hsizetype="MinimumExpanding" vsizetype="Fixed">
+                 <horstretch>0</horstretch>
+                 <verstretch>0</verstretch>
+                </sizepolicy>
+               </property>
                <property name="toolTip">
                 <string>Insert your custom label here or select one from the list.</string>
                </property>
@@ -966,6 +972,11 @@
  <layoutdefault spacing="6" margin="11"/>
  <customwidgets>
   <customwidget>
+   <class>KRichTextEdit</class>
+   <extends>KTextEdit</extends>
+   <header>krichtextedit.h</header>
+  </customwidget>
+  <customwidget>
    <class>KLineEdit</class>
    <extends>QLineEdit</extends>
    <header>klineedit.h</header>
@@ -982,9 +993,9 @@
    <container>1</container>
   </customwidget>
   <customwidget>
-   <class>KRichTextEdit</class>
+   <class>KTextEdit</class>
    <extends>QTextEdit</extends>
-   <header>krichtextedit.h</header>
+   <header>ktextedit.h</header>
   </customwidget>
   <customwidget>
    <class>CoverLabel</class>
Comment 3 Johannes Obermayr 2010-05-21 19:43:21 UTC
It is not fixed in 2.3.0.80svn20100518 git snapshot on openSUSE ...
Comment 4 Myriam Schweingruber 2010-08-12 09:37:03 UTC
Johannes: Could you please check with 2.3.1 final or later?
Comment 5 Johannes Obermayr 2010-08-13 15:18:39 UTC
commit ea5a9b80f5e17716804c4e637fed25ed9daeff1e
Author: Johannes Obermayr <johannesobermayr@gmx.de>
Date:   Fri Aug 13 15:18:14 2010 +0200

    TagDialog: Correct maxSize -> minSize in label widget
    
    This prevents the associated "Label:" label from being truncated for translations of "Label:".
    
    BUG: 235957

diff --git a/ChangeLog b/ChangeLog
index 74ba715..3dd349b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -42,6 +42,7 @@ VERSION 2.3.2-Beta 1
       Patch by Richard Longland <rlongland@hotmail.com>.
 
   BUGFIXES:
+    * Finally don't truncate the "Label:" label in TagDialog. (BR 235957)
     * Fix crash when right clicking on children of "No labels". NoLabel item is
       now a Data item. (BR 243825)
     * Fix regression in Dynamic Collections. For files that were scanned when
diff --git a/src/dialogs/TagDialogBase.ui b/src/dialogs/TagDialogBase.ui
index 4b33809..290c64e 100644
--- a/src/dialogs/TagDialogBase.ui
+++ b/src/dialogs/TagDialogBase.ui
@@ -749,10 +749,10 @@
             <layout class="QHBoxLayout" name="horizontalLayout_5">
              <item>
               <widget class="QLabel" name="label">
-               <property name="maximumSize">
+               <property name="minimumSize">
                 <size>
                  <width>40</width>
-                 <height>16777215</height>
+                 <height>0</height>
                 </size>
                </property>
                <property name="text">