Bug 233605 - [PATCH] to lyricwiki script
Summary: [PATCH] to lyricwiki script
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: Context View (show other bugs)
Version: unspecified
Platform: Debian testing Linux
: NOR normal
Target Milestone: 2.3.1
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-07 14:41 UTC by Oleg
Modified: 2010-04-20 18:32 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 2.3.1

Attachments
lyricwiki script (8.61 KB, application/x-javascript)
2010-04-07 14:42 UTC, Oleg 		Details
forgot to remove debug message in previous attachment (8.59 KB, application/x-javascript)
2010-04-07 14:57 UTC, Oleg 		Details
oops. sorry, one more bug fixed (8.63 KB, application/x-javascript)
2010-04-07 15:15 UTC, Oleg 		Details
lyricwiki.patch (11.19 KB, patch)
2010-04-08 07:09 UTC, Oleg 		Details
lyricwiki.patch (11.22 KB, patch)
2010-04-08 08:42 UTC, Oleg 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Oleg 2010-04-07 14:41:00 UTC 
Version:            (using KDE 4.3.4)
OS:                Linux
Installed from:    Debian testing/unstable Packages

Sometimes current lyricwiki script returns "*/" instead of lyrics.
It parse raw html page. I think this is bad way.
I made some changes in this script. I get lyrics using some useful wikimedia API functions.

I'll attach whole script instead of patch, because patch is bigger than script.
Comment 1 Oleg 2010-04-07 14:42:58 UTC 
Created attachment 42568 [details]
lyricwiki script
Comment 2 Oleg 2010-04-07 14:57:54 UTC 
Created attachment 42569 [details]
forgot to remove debug message in previous attachment

fix
Comment 3 Oleg 2010-04-07 15:15:16 UTC 
Created attachment 42571 [details]
oops. sorry, one more bug fixed
Comment 4 Sven Krohlas 2010-04-07 21:06:25 UTC 
Well, the size doesn't matter in that case, we need a patch.

Even better: a merge request at gitorious: http://gitorious.org/amarok/amarok/merge_requests
Comment 5 Oleg 2010-04-08 07:09:50 UTC 
Created attachment 42584 [details]
lyricwiki.patch

ok, here it is
Comment 6 Oleg 2010-04-08 08:42:03 UTC 
Created attachment 42587 [details]
lyricwiki.patch

last version, I think
Comment 7 Oleg 2010-04-11 19:35:36 UTC 
Merge request:
http://gitorious.org/amarok/amarok/merge_requests/164
Comment 8 Mark Kretschmann 2010-04-20 18:16:35 UTC 
Patch merged, thanks!


commit 2bc8ff6efb395f78fd82af8935fbfa272f3cd70f
Author: Oleg G <milfoil@host-172-22-139-17.academ.local>
Date:   Sat Apr 17 01:37:14 2010 +0700

   updated lyricwiki script: added support of <lyric> tag and tags correction by API if necessary