Bug 225260 - audioplayercontrol: blocks krunner process dbus'ing player
Summary: audioplayercontrol: blocks krunner process dbus'ing player
Status: RESOLVED WORKSFORME
Alias: None
Product: krunner
Classification: Plasma
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Unspecified
: NOR normal
Target Milestone: ---
Assignee: Jan Gerrit Marker
URL:
Keywords:
: 232912 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-02-02 13:26 UTC by Will Stephenson
Modified: 2010-12-05 15:33 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Backtrace (121.07 KB, text/plain)
2010-04-12 12:12 UTC, Davide Rondini
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Will Stephenson 2010-02-02 13:26:40 UTC
Version:            (using Devel)
Installed from:    Compiled sources

audioplayercontrol blocks krunner for a long time when executing 'play' when no media player is running.

It does this by starting the configured player then calling  'play' on it using QDBusConnection::call() which is blocking.  Since eg amarok takes a long time to handle dbus calls after being started, krunner is blocked until amarok receives and replies to the 'play' command.  

QDBusConnection::call() should be used with QDBus::NoBlock or if a reply needs to be handled, QDBusConnection::callWithCallback()
Comment 1 Davide Rondini 2010-04-12 12:12:45 UTC
Created attachment 42712 [details]
Backtrace
Comment 2 George Kiagiadakis 2010-05-06 22:30:11 UTC
I have also noticed that krunner hangs for long periods of time if audioplayercontrol is enabled, even if I don't try to execute any action from it. It just hangs for some seconds while typing, then it gets back to normal. Disabling audioplayercontrol fixes this issue.
Comment 3 Jan Gerrit Marker 2010-07-14 10:40:55 UTC
SVN commit 1149762 by jangmarker:

Fix performance issues. Change commands up, down, volume= to increase, decrease, volume. They should work now.
CCBUG:225260
CCBUG:226119


 M  +3 -0      TODO  
 M  +51 -39    audioplayercontrolrunner.cpp  
 M  +3 -3      audioplayercontrolrunner_config.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1149762
Comment 4 Matthias Fuchs 2010-12-05 15:27:29 UTC
*** Bug 232912 has been marked as a duplicate of this bug. ***
Comment 5 Matthias Fuchs 2010-12-05 15:33:39 UTC
I can't reproduce this bug with trunk.
Could you try it with at least KDE 4.6 Beta 1 and reopen this bug if the problem is still there?