Bug 216977 - delete entry is shown in the context menu when using desktop:
Summary: delete entry is shown in the context menu when using desktop:
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 16.12.2
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2009-12-01 21:16 UTC by Christian Trippe
Modified: 2012-10-30 20:30 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Working for me on Dolphin 2.1 (Chakra). (37.62 KB, image/png)
2012-10-27 07:10 UTC, Adrián Chaves (Gallaecio)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Trippe 2009-12-01 21:16:48 UTC
Version:           1.3 (using 4.3.1 (KDE 4.3.1) "release 9", KDE:KDE4:STABLE:Desktop / openSUSE_11.2)
Compiler:          gcc
OS:                Linux (i686) release 2.6.31.5-0.1-default

1) disable 'show delete menu' in dolphin
2) access some filed via desktop: in the url bar 
3) find the 'delete' entry in the context menu

This works correctly when accessing this files via /home/user/Desktop/, e.g. no 'delete' entry is shown

There is a downstream bug (for KDE 4.1 but the beahviour is the same with 4.3) at https://bugzilla.novell.com/show_bug.cgi?id=552631 including a video, showing the behaviour.
Comment 1 Glen Kaukola 2010-03-17 10:55:47 UTC
It looks like KUrl::isLocalFile(), which is called by DolphinContextMenu::insertDefaultItemActions(), returns false for the desktop protocol.  When false is returned only delete is shown in the menu.

#kde-devel advised against adding a check for the "desktop" url scheme to KUrl::isLocalFile(), as that isn't how it should function.

KFileItem::mostLocalUrl() would probably do the trick on a desktop:/ type, but it's unclear to me at this point as to how I'd use that when all I have is a KUrl object.
Comment 2 Glen Kaukola 2010-04-13 05:56:30 UTC
Posted a potential fix to the review board:
http://reviewboard.kde.org/r/3578/
Comment 3 Jeroen van Meeuwen (Kolab Systems) 2012-08-24 16:20:04 UTC
Resetting assignee to default as per bug #305719
Comment 4 Adrián Chaves (Gallaecio) 2012-10-27 07:10:18 UTC
Created attachment 74821 [details]
Working for me on Dolphin 2.1 (Chakra).
Comment 5 Christian Trippe 2012-10-30 20:30:07 UTC
It's indeed fixed also for me.

(However I cannot find the show delete entry in context menu in dolphin any longer, it only seems to be available in konqueror, but that's another bug/or by design.)