Bug 215924 - When editing tag with playlist inline editor, the enter Key does not commit changes.
Summary: When editing tag with playlist inline editor, the enter Key does not commit c...
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: Playlist (show other bugs)
Version: 2.3-GIT
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-24 04:39 UTC by Pierre Dumuid
Modified: 2009-11-25 23:46 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pierre Dumuid 2009-11-24 04:39:56 UTC
Version:            (using KDE 4.3.3)
OS:                Linux
Installed from:    Gentoo Packages

When editing tag with playlist inline editor, pressing the enter key does not commit changes.

However, clicking on another track does..

(as of git 910e7b2b5809bb74ed6c8d410ad6976930fdffe8)
Comment 1 Nikolaj Hald Nielsen 2009-11-25 23:46:33 UTC
commit 87ca9246d7751ab9d6df7ec43d6bd19bbdd965a0
Author: Nikolaj Hald Nielsen <nhnFreespirit@gmail.com>
Date:   Wed Nov 25 23:39:04 2009 +0100

    Make pressing the enter key commit the value of the currently active line edit when using the inline editor.
    This one looked soo nice and simpy to do as a quick 10 minute hack. Yeah right!
    I cannot recall the last time something so trivial from a user perspective have lead me to such a huge hack.
    Again, things are complicated by us doing things to Qt it was never meant to withstand, such as having a single
    editor widget in a list view handle multiple "columns" of data at once.
    The only goof thing about this, is that if we later want to change the behaviour of the editor, the event filter
    will allows us almost complte freedom to handle key events as we see fit.
    BUG: 215924