Bug 214056 - Ability to edit / view BPM (Beats Per Minute) tags as per the Amarok1
Summary: Ability to edit / view BPM (Beats Per Minute) tags as per the Amarok1
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: general (show other bugs)
Version: 2.2.0
Platform: Gentoo Packages Linux
: NOR wishlist
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-11 01:35 UTC by Pierre Dumuid
Modified: 2009-11-25 17:18 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pierre Dumuid 2009-11-11 01:35:27 UTC
Version:           2.2.0 (using KDE 4.3.2)
OS:                Linux
Installed from:    Gentoo Packages

In Amarok 1.4 one was able to sort by BPM, and also edit BPM tags.
It would be nice to have this feature back..
Comment 1 Matěj Laitl 2009-11-17 13:32:13 UTC
Yes, I'd also very much appreciate this feature. It's especially handy for DJs who'd like to sort playlist by tempo etc.
Comment 2 Pierre Dumuid 2009-11-17 13:36:03 UTC
I'm personally trying to implement this feature, but I'm very new to the amarok codebase, and am working at it at a very slow rate, (and possibly may have given up by the time you read this.)

In anycase, if anyone plans to work on this, can you please let me know to make sure we don't overlay on the work.

Ta.
Comment 3 Matěj Laitl 2009-11-17 13:47:20 UTC
(In reply to comment #2)
> I'm personally trying to implement this feature, but I'm very new to the amarok
> codebase, and am working at it at a very slow rate, (and possibly may have
> given up by the time you read this.)
> 
> In anycase, if anyone plans to work on this, can you please let me know to make
> sure we don't overlay on the work.
> 
> Ta.

Great! I was also thinking about it since I've alredy done a few patches for Amarok. Can you publish your work-in-progress?

I plan to have a look at patches that added labels to Amarok 2.2.2, adding BPM metadata could be similar.
Comment 4 Pierre Dumuid 2009-11-17 14:19:17 UTC
Ok, my development is here:

git clone git://gitorious.org/~pmdumuid/amarok/pmdumuid-amarok.git

Issue214056-0 - A branch tracking my first attempt at working at this problem
Issue214056-1 - The current branch (breaking down the "problem" into 
managable chunks)


My plan to solve this issue is as follows:

1) Add ability textbox to tag edit dialog box
2) Make the textbox actually show the correct value as read from audio file.
 [test for various file types, mp3, ogg, ...]
3) Make changes to the textbox save to file
 [test for various file types, mp3, ogg, ...]
4) Investigate how to add BPM to the Sort bar looking thing.
5) Investigate how to add BPM to the "Playlist Layout Editor"


I've only done step (1) at the moment :P and am part way (I think) through step (2).

(likely need to add BPM to track table in database to enable sorting)

Regards,

Pierre
Comment 5 Pierre Dumuid 2009-11-24 09:39:30 UTC
Implemented in git, and merged in by Mark Kretschmann

5a5b71114e80764deb361ae7256b49e65f60f5ad
Comment 6 Matěj Laitl 2009-11-25 17:18:19 UTC
Thank you veru much, Pierre, you made the new Amarok rocking for all DJs again!