Bug 212967 - click on photo in geolocation view should open the photo
Summary: click on photo in geolocation view should open the photo
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Searches-Map (show other bugs)
Version: 1.0.0
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-03 20:12 UTC by Volker
Modified: 2012-06-27 11:10 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 1.0.0


Attachments
GPSSearch with buttons to select the mouse mode. (186.10 KB, image/png)
2009-11-19 11:25 UTC, Michael G. Hansen
Details
Add buttons to GPSSearch to control mouse mode, against r1050958. (20.21 KB, patch)
2009-11-19 11:26 UTC, Michael G. Hansen
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Volker 2009-11-03 20:12:32 UTC
Version:            (using KDE 4.3.2)
OS:                Linux
Installed from:    Ubuntu Packages

When clicking on a photo on the geolocation map nothing happens. 

It would be very useful if clicking on a photo would open the photo (new window) or would show a bigger version of the photo just like when you click on a photo in the thumbbar.

This would be a great help when e.g. showing people photos. You could then show them the photos only by viewing the map and clicking on specific photos.

it would be nice if this could be implemented.

Btw: Thanks for the OSM view in geolocation - this is great!
Comment 1 caulier.gilles 2009-11-03 22:25:37 UTC
Michael,

This entry is for you (:=)))

Gilles Caulier
Comment 2 Michael G. Hansen 2009-11-05 12:33:53 UTC
You can currently use Ctrl+left mouse button to achieve something similar, more options are shown if you use Help->"What's this?" on the map. It is sort of hidden :-( You are right, left mouse button would probably be a better option.

I hope we will have time during the upcoming coding sprint next week to come up with a better assignment of the mouse interactions, and improve it for the next beta.

Michael
Comment 3 Michael G. Hansen 2009-11-19 11:25:24 UTC
Created attachment 38438 [details]
GPSSearch with buttons to select the mouse mode.

During the sprint, Marcel suggested to add buttons to control the mouse interaction, as in Okular. Here is a screenshot with the new buttons below the map (they do not have icons yet):
P: Pan mode, for browsing around the map. Nothing happens when you click on an image, except if you use shift/control as specified in the "What's this" text.
F: Filtering, reduces the number of images show in the icon view to the images you have clicked on (shift for choosing multiple).
S: Selection, mark the images you click on as selected in the icon view.
Z: Zoom into groups, zooms in until the group of images you have clicked on fills the entire visible map.

Also, if the user has not defined a search rectangle yet, a text is displayed inviting him to make a selection.

Due to the new icons, the text box for naming the saved searches will have to be moved below the icons.
Comment 4 Michael G. Hansen 2009-11-19 11:26:35 UTC
Created attachment 38439 [details]
Add buttons to GPSSearch to control mouse mode, against r1050958.
Comment 5 caulier.gilles 2009-11-19 11:33:42 UTC
I recommend to reduce the space between icon to optimize layout.

I recomment too to use icon instead letter in button to be homogenous with the rest of the gui.

Anyway, the rest is fien for me...

Gilles
Comment 6 Marcel Wiesweg 2009-11-19 12:34:12 UTC
Generally I like it.

I don't know if it's technically possible currently, but at least in the long term I would like to get rid of requiring a user pressing control.
What I mean is a big button, "Make selection" with full text and icon, preferably on the top. When this is pressed, the next drag operation is done as if Ctrl is pressed. Ideally, the cursor reflects this state as well. So no user needs to know how to do this control+press thing. (certain users dont know what is the control button. users dont know they have to keep it pressed while dragging. I'm happy if they know how to drag a mouse. I'm serious ;-) )

For the four small buttons you added now, maybe grouping them in a tool button or combo box would be an option? To determine the behavior when an item is clicked, not the free map. Or use two rows. Default would be either selection of filtering.
Comment 7 Andi Clemens 2009-11-19 12:49:12 UTC
Marcel,

shouldn't this work with a simple toggleButton?
Press it once, it is toggled.
Now when dragging with the mouse, make the selection.
On mouse release, reset the button.

This should work...?
Comment 8 Andi Clemens 2009-11-19 12:53:42 UTC
By toggleButton I mean a buttonw ith "setCheckable(true)"
Comment 9 Marcel Wiesweg 2009-11-19 13:03:04 UTC
You are right, there are two basic approaches: A toggable state (pan vs. select) and "load and fire" (always pan, to make a selection, prepare it each time with a click)

A toggable state was my initial idea, but then I thought in the typical workflow you do more panning then selecting; when you made a selection and intend to pan, another click would be required; when you just made a selection and click again, and expect it to pan because it did before, you reset your selection instead.

For power users, there is still Ctrl+Press.
Comment 10 Johannes Wienke 2009-11-19 13:08:54 UTC
What about using a theme used in other application: left click for selection work and middle or right click for panning? That's especially often used in games where you have the same problem that you can do multiple things with the mouse.
Comment 11 Andi Clemens 2009-11-19 13:11:40 UTC
Actually I thought of resetting the toggle state after the mouseReleaseEvent.

For example:
Button is called "Make selection", it is not checked by default => panning is active.

Now you click this button => make selection
Click and drag in Marble and after mouse release, the button is reset again (not checked) => panning active again.

So as soon as you click in marble and release, the button is reset again.
Comment 12 Marcel Wiesweg 2009-11-19 13:29:01 UTC
Andi: Yes, that's good. I agree with this idea.

Johannes: My laptop does not have a middle mouse button ;-)
Comment 13 caulier.gilles 2009-11-19 13:32:28 UTC
Marcel, to simulate middle button, press on right and left buttons at the same time (:=)))...

Gilles Caulier
Comment 14 Andi Clemens 2009-11-19 13:44:21 UTC
Gilles,

this doesn't work all the time, with my Acer laptop it doesn't, and with the Macbook it only does a singleclick, panning is not possible.
Comment 15 Johannes Wienke 2009-11-19 14:04:16 UTC
But using the right key would still work? ;)
Comment 16 Michael G. Hansen 2009-11-21 22:59:20 UTC
Thanks for your comments!

Gilles said:
> I recomment too to use icon instead letter in button to be homogenous with the rest of the gui.
Any suggestions who can make icons? I would like to use a hand for Pan, for "Zoom into group" I set "zoom-select-fit" for now. For "Select" one could use an arrow-shaped cursor hitting a blue icon, and for filtering a cursor hitting an icon while other icons are faded. But I'm not very good at making icons.

Marcel:
I would like to keep the buttons separate, then it is faster to switch between the modes.

As for a new Ctrl+LMB selection mode, we will have to re-implement the selection code which is currently in Marble (later).

Michael
Comment 17 caulier.gilles 2009-11-22 08:35:16 UTC
About Icons :

It's definitively not a task for developpers. In forst, look in Oxygen reprository from your computer if an existing one can be used as well. If not, ask to Fri13 in IRC if it can make one for you...

Gilles Caulier
Comment 18 Marcel Wiesweg 2009-11-22 11:59:17 UTC
Some suggestions: For Pan, "transform-move", for filtering there is "view-filter", for select "edit-select".
I usually use dolphin with preview enabled in /usr/share/icons/oxygen/, then change the icons in the source, compile, and try others when I am not satisfied.
Comment 19 Michael G. Hansen 2009-11-22 17:18:33 UTC
SVN commit 1052838 by mghansen:

GPSSearch: Add buttons to change the mouse mode to pan, filter, select or zoom into group.

If no search area has been selected on the map, show a message inviting the user to define one.

BUG: 212967



 M  +2 -1      NEWS  
 M  +26 -0     libs/imageproperties/imagepropertiesgpstab.cpp  
 M  +199 -74   libs/imageproperties/markerclusterholder.cpp  
 M  +13 -0     libs/imageproperties/markerclusterholder.h  
 M  +34 -0     libs/imageproperties/worldmapwidget.cpp  
 M  +5 -0      libs/imageproperties/worldmapwidget.h  
 M  +51 -2     utilities/gpssearch/gpssearchview.cpp  
 M  +45 -1     utilities/gpssearch/gpssearchwidget.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1052838