Bug 205920 - Queue lost when switching between random modes in playlist
Summary: Queue lost when switching between random modes in playlist
Status: RESOLVED WORKSFORME
Alias: None
Product: amarok
Classification: Applications
Component: Playlist (show other bugs)
Version: 2.3-GIT
Platform: unspecified Linux
: NOR normal
Target Milestone: 2.3.1
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-01 21:20 UTC by Harley Laue
Modified: 2009-12-23 12:39 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Harley Laue 2009-09-01 21:20:49 UTC
Version:           git commit 55a382f3bd2064adcf (using KDE 4.3.0)
Compiler:          gcc version 4.4.1 x86_64-unknown-linux-gnu
OS:                Linux
Installed from:    Unlisted Binary Package

When tracks are queued in a playlist and the Playlist Random mode is changed (Off->Tracks, Tracks->Albums, etc) the currently queued tracks are "lost." More accurately they're probably set to zero. When you right click on one of the previously queued tracks the option to Dequeue the track(s) is still available.

For this example we'll use three tracks to exhibit the incorrect behavior.
Steps to reproduce:
1) Have a play list with at least three tracks
2) Turn Random->Tracks On
3) Start playing the first track (and do the following steps while it's still playing)
4) Queue the third track
5) Turn Random->Tracks Off
6) The third track says it's no longer queued but when you right click it the option to dequeue it is available.
7) When track one is finished track two is played

Correct behavior would be:
(Queue is cleared)
5) Turn Random->Tracks Off
6) Third track is removed from the queue
7) When track one is finished track two is played

Or perhaps a better correct behavior would be:
(Queue is maintained between changing Random modes)
5) Turn Random->Tracks Off
6) When track one is finished track three is played.

Obviously this is just the base case and it's going to be either all queued tracks are removed or all queued tracks are preserved when the Random mode is changed. My preference would probably be towards the later since it would be frustrating to queue 10 tracks that you want to hear, after which you change the random mode and the queue is cleared.
Comment 1 Myriam Schweingruber 2009-09-01 23:34:11 UTC
Teo, I think you fixed something similar earlier, didn't you?
Comment 2 Harley Laue 2009-09-02 00:11:00 UTC
(In reply to comment #1)
> Teo, I think you fixed something similar earlier, didn't you?
Yes, he did (it was another bug I reported.)

From #amarok
<Teo`> losinggeneration: please report it
<losinggeneration> will do
<Teo`> losinggeneration: makes it much easier to track so it doesn't slip past beta2
Comment 3 Kuba Serafinowski 2009-09-20 21:03:07 UTC
confirmed in revision 1258469
Comment 4 Myriam Schweingruber 2009-11-16 18:01:30 UTC
Any news about this?
Comment 5 Teo Mrnjavac 2009-12-23 12:39:54 UTC
I can't reproduce it now though I do believe that it was valid in the past.
Can the reporter please try a recent git master and reopen if the issue still remains?