Version: (using KDE 4.2.4) Installed from: Fedora RPMs If 3 packages require a system restart, and 4 other require a logout, 7 notification window appear on top of each other. I would rather expect one or two windows with a summary.
Created attachment 35772 [details] Screenshot showung the bug
Which version of KPackageKit are you using? The correct behavior was to only show a different notification *IF* it's more important, like first was "you need to logout" then "you need to restart" in this case you would have two.. I tested that a lot but you version might not have the fix..
I'm having the exact same problem on Fedora 11 which I think has the latest version of kpackagekit, 0.4.1.1
When an update begins, before finishing downloading and committing changes, numerous notifications to restart or logout appear. I think this a dangerous behavior for someone not well attentionned that can lead to a failed update with consequences on the system stability. My system is a fedora 11 with gcc version 4.4.0, kpackagekit version 0.4.1.1, Kde 4.2.4
Sorry, I thought I had this fix into 0.4.1 series, but it wasn't even commited... it's fixed in 0.4.2, but the various popups is Fedora backend problem.
Should you also return early if restart type is RestartNone or UnknownRestartType? Otherwise I think you leak a KNotification. Though I think in the first case you should never get that far but the second case can happen. I think it would happen with PackageKit master, since at a glance it looks like packagekit-qt has no equivalents of the new PK_RESTART_ENUM_SECURITY_SESSION or PK_RESTART_ENUM_SECURITY_SYSTEM restart types. But I don't know when packagekit will start using them.
(In reply to comment #5) > Sorry, I thought I had this fix into 0.4.1 series, but it wasn't even > commited... > it's fixed in 0.4.2, but the various popups is Fedora backend problem. Sorry, but what do you mean by "Fedora backend problem"? Should we do a bug report somewhere else? If yes, where?
Hmm I think a bug against PackageKit in Fedora might do it, the problem is that the yum backend is the one resposible for emiting a restartSignal, KPackageKit just show it, and I don't think KPK should hold them till the end of the transaction, yum backend is the one that should do it. The where is probably something like bugs.fedora.org (sorry if this address is wrong but i don't use fedora).
(In reply to comment #8) > Hmm I think a bug against PackageKit in Fedora might do it, the problem is that > the yum backend is the one resposible for emiting a restartSignal, KPackageKit > just show it, and I don't think KPK should hold them till the end of the > transaction, yum backend is the one that should do it. The where is probably > something like bugs.fedora.org (sorry if this address is wrong but i don't use > fedora). Thanks for your reply, I reported the bug here : https://bugzilla.redhat.com/show_bug.cgi?id=517907 . Wait and see.