Bug 197566 - Improve layout of advanced search dialog
Summary: Improve layout of advanced search dialog
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: general (show other bugs)
Version: 2.1.1
Platform: Gentoo Packages Unspecified
: NOR normal
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-23 03:24 UTC by Elias Probst
Modified: 2009-06-23 15:40 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
The screenshot showing the not-wrapped text expanding the dialog's width (105.84 KB, image/png)
2009-06-23 03:24 UTC, Elias Probst
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Elias Probst 2009-06-23 03:24:05 UTC
Version:           2.1.1 (using KDE 4.2.4)
Installed from:    Gentoo Packages

The layout of the advanced search dialog is not yet perfect:

As in some translations (like German, see the screenshot in the attachment) need more space for the text on top of the dialog, the dialog is expanded to the full width needed by the text when opening it.
Instead the text should be wrapped and the width of the dialog when opening should be set to it's minimum needed size.

I've tried it by doing this changes to the *.ui file but didn't succeed:

--- EditFilterDialog.ui.orig    2009-06-23 02:51:16.000000000 +0200
+++ EditFilterDialog.ui 2009-06-23 02:52:47.000000000 +0200
@@ -39,6 +39,9 @@
      <property name="text" >
       <string>Edit the filter for finding tracks with specific attributes, e.g. a track that has a length of three minutes.</string>
      </property>
+     <property name="wordWrap">
+      <bool>true</bool>
+     </property>
     </widget>
    </item>
    <item row="1" column="0" colspan="2" >

Could someone with a little more UI layout knowledge take a look at this again?

Furthermore a maximum width for the dialog should be specified. Currently it is possible stretching it endless which makes it look very strange.
Comment 1 Elias Probst 2009-06-23 03:24:50 UTC
Created attachment 34756 [details]
The screenshot showing the not-wrapped text expanding the dialog's width
Comment 2 Mark Kretschmann 2009-06-23 15:40:37 UTC
SVN commit 985772 by markey:

Enable word-wrap for the label at the top of the Edit Filter dialog.

Without wrapping, the dialog became giant (think THE HULK) with some
translations.

BUG: 197566

 M  +1 -0      EditFilterDialog.cpp  
 M  +104 -102  EditFilterDialog.ui  


WebSVN link: http://websvn.kde.org/?view=rev&revision=985772