Bug 194328 - Queue currently playing song doesn't work correctly when Random Tracks is on
Summary: Queue currently playing song doesn't work correctly when Random Tracks is on
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: Playlist (show other bugs)
Version: 2.3-GIT
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-27 18:20 UTC by Harley Laue
Modified: 2009-09-01 17:31 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Harley Laue 2009-05-27 18:20:05 UTC
Version:           2.0.90 (using KDE 4.2.3)
Compiler:          4.3.3 Ubuntu 4.3.3-5ubuntu4
OS:                Linux
Installed from:    Ubuntu Packages

When a track is being played from a playlist, if you queue the currently playing song, it doesn't repeat the song and remove it from the queue. Instead it goes on to the next song and subtracts the song from 1 to 0 and never goes back to play the song. It works correctly when playing the playlist sequentially, but when Playlist->Random->Tracks is on, it just skips the queue selection of the currently playing song
Comment 1 jonny sutton 2009-06-09 13:03:04 UTC
I can confirm this behaviour in Suse 11.1 using 2.1
Comment 2 Alexey Shildyakov 2009-06-25 14:38:54 UTC
Cannot confirm it on Amarok 2.2-SVN
Comment 3 Myriam Schweingruber 2009-06-25 16:42:38 UTC
Neither can I, seems solved in 2.2-SVN
Comment 4 Harley Laue 2009-06-25 17:15:51 UTC
Queuing the currently playing track does not currently work in SVN. If it's queued it should repeat that song and then dequeue it. It doesn't dequeue it either, right clicking on the song after it's done and skipped playing it the second time the option is to dequeue it and not to queue it. 

To duplicate:
1) Turn on random tracks
2) Start playing a track in the playlist
3) Queue the track
4) When the track is finished it goes on to a different track (the bug)
Comment 5 Alexey Shildyakov 2009-06-25 17:48:00 UTC
Yes. In this case, I confirm it.
Comment 6 Myriam Schweingruber 2009-06-25 20:52:17 UTC
Yes, confirmed too, forgot to set the random mode previously.
Comment 7 Teo Mrnjavac 2009-08-20 21:33:02 UTC
This seems to be fixed in current git, I can't reproduce.
Comment 8 Harley Laue 2009-09-01 00:22:16 UTC
Perhaps comment #4 wasn't clear enough... So please follow these directions to reproduce the bug:
1) Turn on random tracks
2) Add two tracks to a playlist
3) Start playing a track in the playlist
4) Queue the track that is currently playing
5) When the track is finished it goes on to a different track (the bug)

The correct behavior:
3) Start playing a track in the playlist
4) Queue the track that is currently playing
5) The currently playing track is played again

Also, it currently removes the queue'd icon from the track, but if you right click the track that was supposed to be played, it gives the option to dequeue it. This indicates that its queue possition is being deincremented (to zero) but it's still considered queued.

I hope this clears up any confusion about how to reproduce this bug.
Comment 9 Myriam Schweingruber 2009-09-01 12:53:38 UTC
True, this is still not fixed here, git build of 2 minutes ago.
Comment 10 Teo Mrnjavac 2009-09-01 16:12:24 UTC
Oops! I must have misunderstood the directions then. I'll take a closer look.
Comment 11 Teo Mrnjavac 2009-09-01 16:55:32 UTC
Ok, I can confirm this and I have also discovered other weird Random navigator behaviour, not only with queuing.
Comment 12 Teo Mrnjavac 2009-09-01 17:31:32 UTC
commit 4ed45244987b2b52dfe23b4445c5b6c18a3caec5
Author: Teo Mrnjavac <teo@getamarok.com>
Date:   Tue Sep 1 17:24:28 2009 +0200

    Correctly handle queuing in the RandomTrackNavigator.
    BUG: 194328