Version: 2.0.90 (using 4.2.2 (KDE 4.2.2), Kubuntu packages) Compiler: cc OS: Linux (i686) release 2.6.28-11-generic The "Prefer tracks" menu entry doesn't get enabled/disabled correctly: The status is not updated when changing the shuffle mode but only when I start amarok, i.e. when I disable shuffle while amarok runs the submenu stays available and when I enabled it while it runs I can't change the wax tracks are preferred. This is Amarok 2.1 Beta from kubuntu-unstable
I have the same issue with the current trunk. Attached patches fixes it for me, but it also changes the behaviour of SelectionAction in general to prevent the preferred (or favoured, as the source calls it) option from being lost when that submenu is disabled, which might have unwanted side-effects for other SelectionActions.
Created attachment 33317 [details] Fox for reported problem - the two removed lines could have unintended side-effects (see last comment) - I'm sorry if the style is wrong or something similar, this is my very first touch with the amarok source ;-)
Could somebody look at this patch please?
Could someone please add [patch] to the title, since it seems to be common policy to mark reports with patches attached this way? I didn't know that when I reported the problem.
Fixed in Git revision 5a8cc53.
Git revision 824dc1cb3789f698af6792f15de85d8d0628e6d9 completely disabled the "favour tracks" menu, making the situation even worse than it was when I opened this bug... why that? Adding author of that revision as CC - I hope this is the usual workflow here.
(In reply to comment #6) > Git revision 824dc1cb3789f698af6792f15de85d8d0628e6d9 completely disabled the > "favour tracks" menu, making the situation even worse than it was when I opened > this bug... why that? That's because the code for this feature was not yet implemented then. Stay tuned for an update, though ;)
commit f1a0b2817769e58ff4f476c9f62e75e7b7cbf0bd Author: Edward Hades <edward.hades@gmail.com> Date: Tue Aug 18 12:35:20 2009 +0400 Added support for Favored random tracks mode. src/ActionClasses.cpp | 3 +- src/CMakeLists.txt | 1 + src/playlist/PlaylistActions.cpp | 8 ++- .../navigators/FavoredRandomTrackNavigator.cpp | 104 ++++++++++++++++++++ .../navigators/FavoredRandomTrackNavigator.h | 44 ++++++++ 5 files changed, 158 insertions(+), 2 deletions(-)