Bug 182964 - Reload pages with frames doesn't work correctly
Summary: Reload pages with frames doesn't work correctly
Status: CONFIRMED
Alias: None
Product: konqueror
Classification: Applications
Component: khtml (show other bugs)
Version: 4.7.4
Platform: Unlisted Binaries Linux
: NOR normal
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords: testcase, triaged
Depends on:
Blocks:
 
Reported: 2009-02-03 10:33 UTC by Andrea Iacovitti
Modified: 2012-03-10 22:14 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
zipped testcase (1.06 KB, application/x-zip)
2009-02-03 11:10 UTC, Andrea Iacovitti
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrea Iacovitti 2009-02-03 10:33:41 UTC
Version:            (using KDE 4.1.4)
OS:                Linux
Installed from:    Unspecified Linux

Hi,
i hope bug #66958 will be reopened. Reloading pages with frames in konqueror is broken again. The bug has reappeared after revision 825638. I _verified_ that after (re)compiling kdelibs 4.1.4 with the follow patch applied (that reverts part of 825638):

--- kdelibs/khtml/khtml_part.cpp	2009-01-07 00:32:40.000000000 +0100
+++ kdelibs/khtml/khtml_part.cpp	2009-02-03 08:03:52.000000000 +0100
@@ -681,7 +681,8 @@
       isFrameSet = htmlDoc->body() && (htmlDoc->body()->id() == ID_FRAMESET);
   }
 
-  if (isFrameSet && d->isLocalAnchorJump(url) && browserArgs.softReload)
+  if (isFrameSet && urlcmp( url.url(), this->url().url(), KUrl::CompareWithoutTrailingSlash | KUrl::CompareWithoutFragment )
+                 && browserArgs.softReload)
   {
     QList<khtml::ChildFrame*>::Iterator it = d->m_frames.begin();
     const QList<khtml::ChildFrame*>::Iterator end = d->m_frames.end();

Probably reverting the above breaks other things....

Cheers,
Andrea.
Comment 1 Andrea Iacovitti 2009-02-03 11:10:21 UTC
Created attachment 30895 [details]
zipped testcase

The page has 3 frames, in each there is a link to kde site. After navigate inside frames, if konq reload button is pressed , the initial page is loaded: this is not the case of ff3 and ie6.
Comment 2 Dominik Tritscher 2009-06-20 14:49:32 UTC
Still the same behaviour in konqueror 4.2.90