Version: 2.0 (using Devel) OS: Linux Installed from: Compiled sources From my observations, the required items are: * A music file (tested with MP3, on read-only filesystem) - without tags - filename formatted like "artist - title.mp3" Then, from the playlist, I open the tag editor, and go to the "Guess tags" dialog, advanced tab, with the following options set: * "Edit case" with "Title case" * Remove trailing spaces * Replace underscores Then: (1) use the format "[%artist] - %title" and press OK (which does not yield results). (2) open the guessing dialog again, just change the format to "%artist - %title" (which would yield a result), press OK After that, Amarok, along with the KDE desktop, becomes completely unresponsive with 100% CPU use, and needs to be killed (TERM signal works).
Created attachment 30065 [details] Backtrace generated by sending a SIGSEGV to the hanging application Thread 1 looks promising
Created attachment 30077 [details] Fix for case conversion code in the tag guesser Case conversion is buggy. The patch (against r908562) provides a rewrite and slight refactoring of the relevant code.
SVN commit 908597 by mrnjavac: Rewrite of the case conversion code in TagGuesser and fix for an infinite loop bug. Thanks Nicos Gollan for the patch. BUG: 180164 M +51 -29 TagGuesser.cpp M +2 -0 TagGuesser.h WebSVN link: http://websvn.kde.org/?view=rev&revision=908597
Created attachment 30107 [details] New patch This patch is a slight refinement. The case conversion code is now completely outside the TagGuesser. There's mostly a single change: apostrophes are now handled as word characters, so e.g. "that's" will not be converted to "That'S". The whole thing is a language-specific bag of fleas, but it should now be more maintainable. I also have a set of unit tests using Qt's framework floating around, if anybody should be interested.
Created attachment 30108 [details] Even newer patch, should (almost) comply with coding guidelines I hope this one is better. Should also make r908979 unnecessary.
Your patch is being reviewed. We appreciate your fix to adhere to our coding style guidelines.
reopening so we don't forget about the patch
Patch reviewed and committed, again thanks Nicos Gollan.