Bug 180023 - Do not show rating for tracks outside of collection
Summary: Do not show rating for tracks outside of collection
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: Context View (show other bugs)
Version: 2.0-SVN
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-08 13:59 UTC by Justin Heesemann
Modified: 2009-12-09 11:28 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Heesemann 2009-01-08 13:59:26 UTC 
Version:           2.x (using Devel)
Compiler:          gcc 4.3.2 
OS:                Linux
Installed from:    Compiled sources

I have a lot of songs, which are not in my collection. When I play one, the "Current Track Info" applet lets me rate the song by setting stars. Only the next time that I play this song, the rating again only shows zero stars.

Either amarok should save the stars in some kind of id3 tag for songs not in the collection or don't let me rate those songs at all. I would prefer it to save that rating somewhere though.. would help me to later add only the good songs to the collection :)
Comment 1 Mark Kretschmann 2009-01-08 14:09:08 UTC 
Agreed, showing the rating for tracks that cannot be rated is not useful. In fact it could be irritating.
Comment 2 Mark Kretschmann 2009-01-08 14:40:21 UTC 
Ok, I have this fixed in my local Git repository. Will commit to SVN after our branching is done.
Comment 3 Mark Kretschmann 2009-01-08 19:50:29 UTC 
SVN commit 907803 by markey:

Don't show the rating widget for tracks which are not in the collection.

BUG: 180023

 M  +6 -0      CurrentTrack.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=907803