Bug 179836 - settings menu: items order violates HIG
Summary: settings menu: items order violates HIG
Status: RESOLVED FIXED
Alias: None
Product: kate
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Unspecified
: NOR normal
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords:
: 184343 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-01-06 20:40 UTC by Maciej Pilichowski
Modified: 2009-04-23 22:05 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
Current Kate Settings menu with new install and new config (17.89 KB, image/png)
2009-01-12 11:09 UTC, Anne-Marie Mahfouf 		Details
Patch to fix settings menu (2.71 KB, patch)
2009-04-23 21:12 UTC, Albert Astals Cid 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Pilichowski 2009-01-06 20:40:32 UTC 
Version:            (using Devel)
Installed from:    Compiled sources

settings menu: items order violates HIG

According to HIG (for example) "configure Kate" should be last item. Now it is somewhere in the middle. It is also a regression btw.
Comment 1 Anne-Marie Mahfouf 2009-01-12 11:08:48 UTC 
Confirmed here with a clean install in a new $KDEHOME. The order I have right now is shown on the attachement.
Comment 2 Anne-Marie Mahfouf 2009-01-12 11:09:39 UTC 
Created attachment 30176 [details]
Current Kate Settings menu with new install and new config
Comment 3 Anne-Marie Mahfouf 2009-01-12 16:34:45 UTC 
Maciej, can you tell when it happened by any chance so it would be easier to spot the commit that broke it? Is it a new install and/or a new config file? If not, when was the last install that was OK?
As far as I can see, all other applications are OK in my build.
Comment 4 Maciej Pilichowski 2009-01-12 17:30:42 UTC 
I won't be helpful with it -- because I don't remember the last time I saw this ordered correctly in KDE4 (I don't remember such things if everything is OK). I am sorry.
Comment 5 FiNeX 2009-02-14 21:49:56 UTC 
*** Bug 184343 has been marked as a duplicate of this bug. ***
Comment 6 Christoph Cullmann 2009-04-23 09:38:09 UTC 
If somebody shows me, how to change kateui.rc, will fix this, but I don't know why the other actions are merged above...
Comment 7 Andreas Pakulat 2009-04-23 10:28:23 UTC 
(In reply to comment #6)
> If somebody shows me, how to change kateui.rc, will fix this, but I don't know
> why the other actions are merged above...

Look at ui_standards.rc from kdelibs/kdeui/xmlgui/ and name your actions properly (options_configure instead of settings_configure for example), then you should only need to put the actions into kateui.rc that are not in ui_standards.rc (i.e. your custom Settings actions) and it should just work.

Oh and to get such a custom action to show up in a specific place, find the DefineGroup in ui_standards.rc that you want to append on and use 
<Action name="" append="groupname"/>
Comment 8 Albert Astals Cid 2009-04-23 21:12:48 UTC 
Created attachment 33045 [details]
Patch to fix settings menu

Doing things the simple and correct way to get a nice settings menu
Comment 9 Albert Astals Cid 2009-04-23 21:13:21 UTC 
I forgot to say: "Ok to commit?"
Comment 10 FiNeX 2009-04-23 21:21:26 UTC 
Great!!! the patch works perfectly.
Comment 11 Andreas Pakulat 2009-04-23 21:35:57 UTC 
Yeap, that looks correct, please commit.
Comment 12 Albert Astals Cid 2009-04-23 22:05:18 UTC 
SVN commit 958334 by aacid:

Fix settings menu
Acked by apaku
BUGS: 179836


 M  +4 -7      app/katemainwindow.cpp  
 M  +1 -10     data/kateui.rc  


WebSVN link: http://websvn.kde.org/?view=rev&revision=958334