Bug 178959 - only call askUserToRestoreAutosavedAbandonedSessions from new application instance
Summary: only call askUserToRestoreAutosavedAbandonedSessions from new application ins...
Status: ASSIGNED
Alias: None
Product: konqueror
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
: 183641 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-12-28 13:07 UTC by Marcel Partap
Modified: 2010-03-23 05:24 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel Partap 2008-12-28 13:07:51 UTC
Version:           4.1.86 (KDE 4.1.86 (KDE 4.2 >= 20081221)) (using 4.1.86 (KDE 4.1.86 (KDE 4.2 >= 20081221)), Gentoo)
Compiler:          x86_64-pc-linux-gnu-gcc
OS:                Linux (x86_64) release 2.6.28-rc9-git1

Right now the 'Restore Session' window is shown each time a new window is opened, even if it is just a popup. Could not find a way to distinguish the cases but IMHO this dialog should only be displayed if the application is started externally, not from an existing konqui window or the kbugbuster dialog.
Comment 1 Eduardo Robles Elvira 2009-06-20 20:13:43 UTC
I think that the main problem with that dialog is that it's annoying. In the future I plan to replace it with a page listing the crashed tabs and letting the user select which ones to restore.
Comment 2 Eduardo Robles Elvira 2009-06-20 20:16:29 UTC
This is not a bug, but more like a wish, marking as such
Comment 3 Eduardo Robles Elvira 2009-06-20 20:22:07 UTC
*** Bug 183641 has been marked as a duplicate of this bug. ***
Comment 4 Marcel Partap 2009-06-21 01:08:24 UTC
Well it is annoying indeed because this question comes up for every new window isntance, even popups. Right now i have it commented out locally because i just couldn't take it anymore *g
BTW. when restoring the previous sessions, the 'Minimize Memory Usage' setting is ignored, so only one process is created which opens all of sites of the saved session. Coincidently, one of the spawned tabs takes the whole restored session down again.
Comment 5 nick 2010-03-23 05:24:34 UTC
I think bug 188277 and bug 216603 can be merged into this one.
In addition to 188277's suggestion, I think it should also keep the list of crashed tabs unique by url. I've been "ask me later"ing several times and have had multiple crashes, and now the list on mine shows several urls more than once. (4.4.1)

IMO, a more complete solution would be:
1) only add unique urls to the list (only show each once)
2) add a checkbox by each url, defaulted to checked
3) if possible detect the one that crashed and default it to unchecked
4) add a delete button to allow editing the list (very useful if you know which one crashes, also for "ask me later"ing it when you already have some of the items opened again)
5) add an "open" button that opens the checked items, but doesn't close the window so you can work your way through the list piecewise if necessary to find the problem url
6) perhaps, add an "exclude" button to allow you to mark urls that are known problems, such that they are from then on defaulted to unchecked if they happen to crash a subsequent session