Bug 176445 - Playlist is not "restarted" if played once
Summary: Playlist is not "restarted" if played once
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: Playlist (show other bugs)
Version: 2.0-SVN
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
: 179438 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-11-29 14:14 UTC by S. Burmeister
Modified: 2009-12-09 11:29 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description S. Burmeister 2008-11-29 14:14:57 UTC
Version:           2.0-SVN (using Devel)
OS:                Linux
Installed from:    Compiled sources

If repeat is set to "Off" the playback stops after every song in the playlist was played, as expected. If however the user clicks on Play again after that, only one song is played and playback stops after it.

Either amarok is very strict on "repeat: off" then it should not play any song, sicne all of them have already been played.

Or this is a bug, since clicking play should restart the playlist, i.e. play all songs once again and stop afterwards.
Comment 1 Mark Kretschmann 2008-12-26 08:09:59 UTC
"If repeat is set to "Off" the playback stops after every song in the playlist
was played, as expected." <-- Uhm, that's not the way it's supposed to work ;)

I'm not sure if I misunderstood you here, but what Amarok normally does is to proceed to the next track in the playlist if "Repeat" is off. If that's not the case for you, something is wrong with your setup.

Make sure that you are using the xine Phonon backend. With the GStreamer backend we've heard of odd bugs like these.


Comment 2 S. Burmeister 2008-12-29 11:03:15 UTC
I'm using xine and I think you misread my comment. I got the impression that you read: "stops after every song" instead of "stops after every song was played"

Clicking on Plays with Repeat: Off + Shuffle: Tracks means: play every song in the playlist once, then stop.

If I got the above wrong, please tell me what Repeat: Off should do instead.

This bug can be shown by a simple example. Set amarok to repeat: off and shuffle: Tracks. Now add two songs to the playlist and click Play. Amarok plays each song once and stops, expected.

Now click Play again and amarok will play one song once and stop, which is a bug IMO, since the user "restarted" the playlist by clicking on Play.

If it was not a bug the user would have erase the playlist and create a new one with the same set of songs, before being able to listen to it again. alternatively the user could set Repeat: Playlist, which would mean that the playlist is played endlessly.

You can also compare it to a hardware CD-Player. If you enable Shuffle only, it will play all songs once and stop. If you then press the Play button again, it will play all songs once again and stop etc. That's how it is supposed to work and what users are used to from other playback devices.

It might be debatable whether clicking Play with Shuffle: Off should restart the playlist as well, i.e. go to the first item, but for shuffle the current behaviour is a bug.
Comment 3 Dan Leinir Turthra Jensen 2008-12-29 11:32:09 UTC
Just as a clarification: You may want to look at the difference between the two terms Shuffle and Random :) Shuffle is what you do with cards, random is just that: random :) Amarok is able to show the new order when you use the Shuffle command, and does so (you will see all the items in the playlist change position). Random playback will always choose a new random track on track change, and as such is *different* to having the data in the playlist ordered, but the playback order shuffled. Your very consistent use of the term Shuffle in place of Random seems to indicate either that you did not understand this, or that there is a problem with the German translation...

What you have highlighted above, though, is that once the playlist reaches the end and stops, it is not reset to it's instantiation value, which would be to have the *first* track highlighted as the current track (right now the last track remains marked as current track, and causes the problem you mention).
Comment 4 S. Burmeister 2008-12-29 12:31:00 UTC
As I have seen many CD players that use shuffle instead of random, those words are almost the same in a audio playback context. Even more so since amarok could shuffle the playlist in memory, i.e. without showing it to the user, to generate a random playback. And it does use random to generate a shuffeled playlist. the only difference is really whether it is applied to the playlist, i.e. visible, or not.

Anyhow, as you noted as well, my understanding and the usage of those two terms do not make any difference regarding the current behaviour being buggy.
Comment 5 Dan Leinir Turthra Jensen 2008-12-29 12:37:46 UTC
There is a subtle but very important difference, however, in how the two things function, and both use cases are important to our users. So, they will stay as they are, we just have to try a bit harder to explain the difference :)

But yup, you've indeed spotted a bug, it was just sort of difficult to figure out what you were actually talking about ;)
Comment 6 S. Burmeister 2008-12-29 12:48:20 UTC
I did not say that amarok should change its usage of those terms. "Shuffle playlist" is currently not available AFAIK (at least not in the menu) and because of the "playlist" certainly straight-forward. So even though "Random" might lack "playback" it should be obvious enough that it does something else.
Comment 7 Dan Leinir Turthra Jensen 2008-12-29 12:55:27 UTC
You are indeed correct, i'm not sure who removed that, but it is definitely wrong and should be put back :)
Comment 8 Mark Kretschmann 2009-01-03 09:08:11 UTC
*** Bug 179438 has been marked as a duplicate of this bug. ***
Comment 9 Michael Zimmermann 2009-03-06 12:36:25 UTC
As mentioned in Bug 179438 this also present without random and without shuffle. 

Imho the bug is as follows:
- Play all songs of a playlist
- Amarok stops (fine)
- The last song in the playlist is selected (maybe)
- Press play: only the selected song is pressed and the end of the playlist is reached 

Expected:
- Play all songs of a playlist
- Amarok stops (fine)
- No song is selected
- Press play: Amarok starts with song #1 of the playlist.
Comment 10 Nikolaj Hald Nielsen 2009-07-16 23:02:31 UTC
SVN commit 998029 by nhnielsen:

Make the playlist "unactivate" the last played track when it reaches the end (as defined by the current navigator). This allows pressing play later on to start the playlist from the top (or whereever the navigator thinks it should start) and not just keep playing the last played track.
BUG: 176445

 M  +16 -0     PlaylistActions.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=998029