Bug 175376 - organize files not working.
Summary: organize files not working.
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: Collections/Local (show other bugs)
Version: 2.0-beta
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-17 09:27 UTC by Evert Vorster
Modified: 2008-11-19 15:29 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Evert Vorster 2008-11-17 09:27:18 UTC
Version:           1.94 (using KDE 4.1.3)
OS:                Linux
Installed from:    Compiled From Sources

I have two directories that I use as music collections. 
One ( Music ) has all my music in complete chaos.
The other, ( Tunes ) is where I want to place songs after I sorted out their tags, genre etc. 

After looking at many music databases, I decided to organize according to genre would suit me best. 

The only way to do this in Amarok is to tick custom in the file organize dialog. I fiddled with it until I got the preview of where the files are supposed to go the way I liked it, and clicked on OK. 

No new directories were created in ( Tunes ). In fact, it looks like exactly nothing happened. 
I double checked that I had write permissions in that directory, and double checked that I have selected the right directory in Amrarok.
Comment 1 Teo Mrnjavac 2008-11-18 19:10:42 UTC
Can you please explain what you did in more detail?
Did you select the right collection in the drop-down box on the top of the dialog?
Did you use basic or advanced mode?
Also please include the complete paths in the description.
Comment 2 Teo Mrnjavac 2008-11-19 02:33:24 UTC
@Evert Vorster: I hope you don't mind if I paste your email here, but it's best if the rest of the Amarok dev team is kept informed.
The more detailed description by the person who reported the bug follows:

Hi there. 

Thanks for looking in to this one. 

In more detail:
I keep my music on a removable hard disk. 

The path to my music collection is:
/media/Evert250GB/Music
This one has about 16,000 songs, in various formats, and various states of completeness.

I want to create a new collection, with only the songs that have been correctly tagged and sorted in:
/media/Evert250GB/Tunes
This directory is currently empty.

So, I select both these folders and index the music collection. 
Once that was done, I picked a band that I knew what genre they are normally classified in to. 
I made sure that all the tags are correct in all the songs. 

Then, in the collection I selected all the songs I want to move to the new directory, and right-click and then Organize files.

Here I select /media/Evert250GB/Tunes as the destination directory. 
I tick "Use Cover Art for folder icons" and "Ignore The in artists names"
Then I tick Custom format.
I drag down stuff until; I get 
Genre/Artist/album
I have tried the same with the advanced tab, too:
%genre/%artist/%album

Also ticked are "Replace spaces with underscores" and "Restrict to ASCII"
Unticked are "VFAT safe names" and "Overwrite destination"

Then I click on OK. 

What I would expect is that a new directory to me made in 
/media/Evert250GB/Tunes, the name of which is the genre of my mp3. 

This directory stays empty, though. 

I checked that I have permissions to write to this directory, and I have actually given EVERYBODY write permission to that directory. Still nothing. 

If you need any more info, please do not hesitate to ask. 
Kind regards,
-Evert Vorster-
Comment 3 Teo Mrnjavac 2008-11-19 02:36:34 UTC
As I understand, you didn't drag down the token "Collection Root", please confirm if that's the case and try with the "Collection Root" token.
If so, the report is invalid but useful nonetheless because it points to something that could be an obvious usability issue.
Comment 4 Teo Mrnjavac 2008-11-19 15:29:59 UTC
Fixed in SVN revision 886544.
Removed "Collection root" Token from Token pool and placed before the FilenameLayoutWidget as a constant token. A path is now forced to begin with the current collection's root.
I can't think of a sane use case where the user would want to operate with OrganizeCollectionDialog on a path outside of the collection root.