Bug 174634 - Bug when appending an album while a track of that album is playing
Summary: Bug when appending an album while a track of that album is playing
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: Playlist (show other bugs)
Version: 2.0-SVN
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-08 16:31 UTC by Mikko C.
Modified: 2009-12-09 11:28 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mikko C. 2008-11-08 16:31:51 UTC
Version:           2.0-SVN (using 4.1.72 (KDE 4.1.72 (KDE 4.2 >= 20081104)), Gentoo)
Compiler:          x86_64-pc-linux-gnu-gcc
OS:                Linux (x86_64) release 2.6.28-rc3

How to reproduce:
- clear the playlist
- load one track from an album (not the first track of the album)
- start playing that track
- append the album to the playlist

Result:
The song which is actually playing is not marked as playing anymore.
Instead the same song in the album is marked as playing. As a result, playback will continue from the song after that, instead of continuing from the first track of the appended album.
Comment 1 Soren Harward 2008-11-08 19:47:11 UTC
As far I'm concerned, this the correct behavior.  The most consistent behavior of the playlist is that it always tries to find the currently playing track within the playlist, and it always proceeds from that point according to the navigator.  Any other behavior would be complicated to program, would behave unintuitively, and would occur in such rare circumstances that it's not worth changing.
Comment 2 Mikko C. 2008-11-08 20:28:51 UTC
I don't see how this could be the correct behavior.
Maybe I didn't explain very well.

Let's say I'm playing "track 8" of an album "Foo".
I really like this track, so I look for the album "Foo" and append it right after "track 8". (I want to listen to the whole album)
When "track 8" is done playing, amarok will continue from "track 9" of the album I appended, skipping all the songs 1-8.

This is a bug imho.
Comment 3 Seb Ruiz 2008-11-08 23:50:06 UTC
I agree with Mikko's explanation and believe it is also a bug.
Comment 4 Nikolaj Hald Nielsen 2008-11-12 21:24:55 UTC
SVN commit 883390 by nhnielsen:

Fix behaviour when inserting a track into the playlist while that track is already playing.
1. If a track is playing but it is not currently in the playlist, and this track is then part of a list of tracks that is added, the first instance of the track will be marked as playing.
2. If a track is playing, and marked as playing in the playlist, and this track is then added to the playlist again, tere will be no change to the track marked as playing.
BUG: 174634 
 


 M  +5 -3      PlaylistModel.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=883390