Bug 173912 - Problem when resuming playback of a track not in the collection
Summary: Problem when resuming playback of a track not in the collection
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: Playlist (show other bugs)
Version: 2.1-SVN
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-30 18:07 UTC by Mikko C.
Modified: 2009-12-09 11:29 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Patch to fix resuming problem (2.59 KB, patch)
2009-03-19 06:09 UTC, Valentin Rouet
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mikko C. 2008-10-30 18:07:15 UTC
Version:           2.0-SVN (using 4.1.71 (KDE 4.1.71 (KDE 4.2 >= 20081023)), Gentoo)
Compiler:          x86_64-pc-linux-gnu-gcc
OS:                Linux (x86_64) release 2.6.28-rc2

To reproduce:

- Activate "Resume playback on start"
- Start playing a track not in the collection (dragged from the Files tab)
- Close Amarok while the song is playing
- Start Amarok
- Playback is correctly resumed but there are 3 problems:

1) No "Current Track Info" is displayed for the resumed song
2) The song isn't highlighted (marked as playing) in the playlist
3) Probably as a consequence of 2), after the song is finished, the playlist will start over (from the first song of the playlist)
Comment 1 Mikko C. 2008-11-21 07:51:03 UTC
This is still valid with svn.
Comment 2 Mark Kretschmann 2008-11-21 12:12:37 UTC
Confirming then, based on Mikko's comment.
Comment 3 Mikko C. 2009-03-08 13:29:59 UTC
problems 2 and 3 are still valid with current trunk.
problem 1 seems to be gone.
Comment 4 Valentin Rouet 2009-03-19 06:09:11 UTC
Created attachment 32252 [details]
Patch to fix resuming problem

This patch fixes the 2 lasts problems when resuming a file that is'nt in the collection.
Comment 5 Valentin Rouet 2009-03-20 02:00:50 UTC
SVN commit 941584 by vrouet:

Bugfixes :
1) Prevent playlist from showing a wrong playing song after adding tracks above it.
CCBUG: 181947

2) Show the current playing song when resuming playback of a track not in the collection.
CCBUG: 173912

 M  +4 -0      ChangeLog  
 M  +4 -0      src/App.cpp  
 M  +6 -1      src/playlist/PlaylistActions.cpp  
 M  +8 -0      src/playlist/PlaylistModel.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=941584
Comment 6 Lydia Pintscher 2009-03-20 09:52:54 UTC
Closing. Thanks Valentin :)