Version: 1.92.2 (using 4.1.2 (KDE 4.1.2), Kubuntu packages) Compiler: gcc OS: Linux (i686) release 2.6.24-19-generic Expected behaviour: When clicking on the mute button again, the volume should return as it was before muting. However, this only happens half of the times, the other half it simply does not work and it keeps the volume muted.
I can't reproduce this. Which phonon backend are you using?
Xine phonon backend o.2
I cannot reproduce this either, with xine-phonon. That said, I'm not totally happy with the implementation: When muting, the volume bar is set to 0. I'd rather see this done like in KMix: When muted, volume bar stays the same, but the volume icon is shown with a red cross overlayed.
This is strange. But mine behaves very strangely. @Mark: about the implementation: I was going to say that .. but you are the devs
i can confirm the non reactive behaviour: click speaker icon -> mutes click again -> unmutes change volume, click icon -> mutes click again -> no reaction so when changing the volume between mutes it doesn't react, you have to click into the volume bar to change it again
I can reproduce the problem following Simon's instructions. The "Mute" implementation currently is a bit of a hack. We should rewrite it in 2.1 so that it doesn't actually change the volume any more. Also we should have an extra icon for muted.
There's another thing that must e fixed: clicking in the volume icon with the right button mutes the sound. It should only bring the context menu.
@Rafael: this has already been fixed
I've done a bit of digging and the only cause I can see is a rogue EngineObserver seems to be muting the engine after it has been unmuted (through EngineObserver::engineVolumeChanged( int ) ). Other than that possibility everything seems to be working fine. Gary
Seems to be a problem with QSlider::setValue() as that is the only bit of the code I haven't been able to rule out (called from Amarok::Slider::setValue() ) I can't give any more details than that unfortunately =( But I have ruled out our code =) Unless theres an EngineObserver I've missed (I've checked the OSD and the VolumeSlider widget) Gary
is ther anything that can be done here?
SVN commit 939855 by kfunk: Make mute button actually work. Committing with good old subversion as git seems to freak out when adding images. M +1 -0 images/CMakeLists.txt AM images/volume_muted_icon.png M +0 -3 widgets/SliderWidget.h M +12 -4 widgets/VolumeWidget.cpp M +4 -1 widgets/VolumeWidget.h
thanks for the quick fix, works great! Author: kfunk Revision: 939855 Commit Message: Make mute button actually work. Committing with good old subversion as git seems to freak out when adding images.