Bug 170665 - Allow to edit the current environment
Summary: Allow to edit the current environment
Status: RESOLVED FIXED
Alias: None
Product: kdevplatform
Classification: Developer tools
Component: util (show other bugs)
Version: git master
Platform: Unlisted Binaries Linux
: VHI wishlist
Target Milestone: ---
Assignee: kdevelop-bugs-null
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-08 09:21 UTC by Andreas Pakulat
Modified: 2010-12-22 22:24 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Pakulat 2008-09-08 09:21:14 UTC
The environment-chooser currently doesn't allow to edit a particular environment, or crreate a new one. Which means you need to close the project options, open the kdevelop settings. Do the stuff there, then go back.

Instead we should have a button to open just the env-kcm directly from env-var chooser.
Comment 1 Milian Wolff 2010-12-22 22:24:01 UTC
commit 51e2c890ef4cbc4e50e8bf0f258dd832d10437a7
branch 4.2
Author: Milian Wolff <mail@milianw.de>
Date:   Wed Dec 22 22:22:20 2010 +0100

    make it possible to configure the environment from the makebuilder config kcm ui
    
    BUG: 170665

diff --git a/projectbuilders/makebuilder/makebuilderpreferences.cpp b/projectbuilders/makebuilder/makebuilderpreferences.cpp
index 25201d9..dff1c8b 100644
--- a/projectbuilders/makebuilder/makebuilderpreferences.cpp
+++ b/projectbuilders/makebuilder/makebuilderpreferences.cpp
@@ -46,6 +46,7 @@ MakeBuilderPreferences::MakeBuilderPreferences(QWidget* parent, const QVariantLi
 
     KDevelop::EnvironmentGroupList env( KGlobal::config() );
     m_prefsUi->kcfg_environmentProfile->addItems( env.groups() );
+    m_prefsUi->configureEnvironment->setSelectionWidget( m_prefsUi->kcfg_environmentProfile );
 
     addConfig( MakeBuilderSettings::self(), w );
 
diff --git a/projectbuilders/makebuilder/makeconfig.ui b/projectbuilders/makebuilder/makeconfig.ui
index cd04226..6c047c1 100644
--- a/projectbuilders/makebuilder/makeconfig.ui
+++ b/projectbuilders/makebuilder/makeconfig.ui
@@ -6,7 +6,7 @@
    <rect>
     <x>0</x>
     <y>0</y>
-    <width>766</width>
+    <width>521</width>
     <height>362</height>
    </rect>
   </property>
@@ -189,7 +189,7 @@
      </property>
     </widget>
    </item>
-   <item row="8" column="0">
+   <item row="9" column="0">
     <widget class="QLabel" name="label_2">
      <property name="text">
       <string>Active Environment &amp;Profile:</string>
@@ -202,23 +202,35 @@
      </property>
     </widget>
    </item>
-   <item row="8" column="1">
-    <widget class="KDevelop::EnvironmentSelectionWidget" name="kcfg_environmentProfile">
-     <property name="sizePolicy">
-      <sizepolicy hsizetype="Expanding" vsizetype="Fixed">
-       <horstretch>0</horstretch>
-       <verstretch>0</verstretch>
-      </sizepolicy>
-     </property>
-     <property name="editable">
-      <bool>false</bool>
-     </property>
-     <property name="insertPolicy">
-      <enum>QComboBox::NoInsert</enum>
-     </property>
-     <property name="autoCompletion">
-      <bool>false</bool>
-     </property>
+   <item row="9" column="1">
+    <widget class="QWidget" name="widget" native="true">
+     <layout class="QHBoxLayout" name="horizontalLayout">
+      <property name="margin">
+       <number>0</number>
+      </property>
+      <item>
+       <widget class="KDevelop::EnvironmentSelectionWidget" name="kcfg_environmentProfile">
+        <property name="sizePolicy">
+         <sizepolicy hsizetype="Expanding" vsizetype="Fixed">
+          <horstretch>0</horstretch>
+          <verstretch>0</verstretch>
+         </sizepolicy>
+        </property>
+        <property name="editable">
+         <bool>false</bool>
+        </property>
+        <property name="insertPolicy">
+         <enum>QComboBox::NoInsert</enum>
+        </property>
+        <property name="autoCompletion">
+         <bool>false</bool>
+        </property>
+       </widget>
+      </item>
+      <item>
+       <widget class="KDevelop::EnvironmentConfigureButton" name="configureEnvironment" />
+      </item>
+     </layout>
     </widget>
    </item>
   </layout>
@@ -244,6 +256,11 @@
    <extends>KComboBox</extends>
    <header location="global">util/environmentselectionwidget.h</header>
   </customwidget>
+  <customwidget>
+   <class>KDevelop::EnvironmentConfigureButton</class>
+   <extends>QToolButton</extends>
+   <header>util/environmentconfigurebutton.h</header>
+  </customwidget>
  </customwidgets>
  <resources/>
  <connections>
@@ -254,12 +271,12 @@
    <slot>setEnabled(bool)</slot>
    <hints>
     <hint type="sourcelabel">
-     <x>557</x>
-     <y>80</y>
+     <x>516</x>
+     <y>74</y>
     </hint>
     <hint type="destinationlabel">
-     <x>566</x>
-     <y>112</y>
+     <x>516</x>
+     <y>102</y>
     </hint>
    </hints>
   </connection>
@@ -270,8 +287,8 @@
    <slot>setEnabled(bool)</slot>
    <hints>
     <hint type="sourcelabel">
-     <x>349</x>
-     <y>76</y>
+     <x>516</x>
+     <y>74</y>
     </hint>
     <hint type="destinationlabel">
      <x>195</x>
Comment 2 Milian Wolff 2010-12-22 22:24:21 UTC
commit 182ae5596257109c1837b888c649c2709aac6130
branch master
Author: Milian Wolff <mail@milianw.de>
Date:   Wed Dec 22 22:22:20 2010 +0100

    make it possible to configure the environment from the makebuilder config kcm ui
    
    BUG: 170665

diff --git a/projectbuilders/makebuilder/makebuilderpreferences.cpp b/projectbuilders/makebuilder/makebuilderpreferences.cpp
index 25201d9..dff1c8b 100644
--- a/projectbuilders/makebuilder/makebuilderpreferences.cpp
+++ b/projectbuilders/makebuilder/makebuilderpreferences.cpp
@@ -46,6 +46,7 @@ MakeBuilderPreferences::MakeBuilderPreferences(QWidget* parent, const QVariantLi
 
     KDevelop::EnvironmentGroupList env( KGlobal::config() );
     m_prefsUi->kcfg_environmentProfile->addItems( env.groups() );
+    m_prefsUi->configureEnvironment->setSelectionWidget( m_prefsUi->kcfg_environmentProfile );
 
     addConfig( MakeBuilderSettings::self(), w );
 
diff --git a/projectbuilders/makebuilder/makeconfig.ui b/projectbuilders/makebuilder/makeconfig.ui
index cd04226..6c047c1 100644
--- a/projectbuilders/makebuilder/makeconfig.ui
+++ b/projectbuilders/makebuilder/makeconfig.ui
@@ -6,7 +6,7 @@
    <rect>
     <x>0</x>
     <y>0</y>
-    <width>766</width>
+    <width>521</width>
     <height>362</height>
    </rect>
   </property>
@@ -189,7 +189,7 @@
      </property>
     </widget>
    </item>
-   <item row="8" column="0">
+   <item row="9" column="0">
     <widget class="QLabel" name="label_2">
      <property name="text">
       <string>Active Environment &amp;Profile:</string>
@@ -202,23 +202,35 @@
      </property>
     </widget>
    </item>
-   <item row="8" column="1">
-    <widget class="KDevelop::EnvironmentSelectionWidget" name="kcfg_environmentProfile">
-     <property name="sizePolicy">
-      <sizepolicy hsizetype="Expanding" vsizetype="Fixed">
-       <horstretch>0</horstretch>
-       <verstretch>0</verstretch>
-      </sizepolicy>
-     </property>
-     <property name="editable">
-      <bool>false</bool>
-     </property>
-     <property name="insertPolicy">
-      <enum>QComboBox::NoInsert</enum>
-     </property>
-     <property name="autoCompletion">
-      <bool>false</bool>
-     </property>
+   <item row="9" column="1">
+    <widget class="QWidget" name="widget" native="true">
+     <layout class="QHBoxLayout" name="horizontalLayout">
+      <property name="margin">
+       <number>0</number>
+      </property>
+      <item>
+       <widget class="KDevelop::EnvironmentSelectionWidget" name="kcfg_environmentProfile">
+        <property name="sizePolicy">
+         <sizepolicy hsizetype="Expanding" vsizetype="Fixed">
+          <horstretch>0</horstretch>
+          <verstretch>0</verstretch>
+         </sizepolicy>
+        </property>
+        <property name="editable">
+         <bool>false</bool>
+        </property>
+        <property name="insertPolicy">
+         <enum>QComboBox::NoInsert</enum>
+        </property>
+        <property name="autoCompletion">
+         <bool>false</bool>
+        </property>
+       </widget>
+      </item>
+      <item>
+       <widget class="KDevelop::EnvironmentConfigureButton" name="configureEnvironment" />
+      </item>
+     </layout>
     </widget>
    </item>
   </layout>
@@ -244,6 +256,11 @@
    <extends>KComboBox</extends>
    <header location="global">util/environmentselectionwidget.h</header>
   </customwidget>
+  <customwidget>
+   <class>KDevelop::EnvironmentConfigureButton</class>
+   <extends>QToolButton</extends>
+   <header>util/environmentconfigurebutton.h</header>
+  </customwidget>
  </customwidgets>
  <resources/>
  <connections>
@@ -254,12 +271,12 @@
    <slot>setEnabled(bool)</slot>
    <hints>
     <hint type="sourcelabel">
-     <x>557</x>
-     <y>80</y>
+     <x>516</x>
+     <y>74</y>
     </hint>
     <hint type="destinationlabel">
-     <x>566</x>
-     <y>112</y>
+     <x>516</x>
+     <y>102</y>
     </hint>
    </hints>
   </connection>
@@ -270,8 +287,8 @@
    <slot>setEnabled(bool)</slot>
    <hints>
     <hint type="sourcelabel">
-     <x>349</x>
-     <y>76</y>
+     <x>516</x>
+     <y>74</y>
     </hint>
     <hint type="destinationlabel">
      <x>195</x>