Bug 164649 - settings menu: HIG violation
Summary: settings menu: HIG violation
Status: RESOLVED FIXED
Alias: None
Product: akregator
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
: 127962 147895 173990 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-06-22 09:16 UTC by Maciej Pilichowski
Modified: 2012-07-26 08:32 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
... (19.86 KB, image/png)
2008-07-24 17:25 UTC, Christophe Marin 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Pilichowski 2008-06-22 09:16:19 UTC 
Version:            (using Devel)
Installed from:    Compiled sources

settings menu: HIG violation

Please reorder menu entries:
http://developer.kde.org/documentation/standards/kde/style/menus/settings.html
Comment 1 Pino Toscano 2008-06-22 09:25:38 UTC 
what should be the problem?
Comment 2 Maciej Pilichowski 2008-06-22 10:09:37 UTC 
Menu entries (in settings) should be ordered in different way (either look at HIG or run Kate and Akregator and compare).
Comment 3 Pino Toscano 2008-06-22 10:17:29 UTC 
Which HIG? You mean http://wiki.openusability.org/guidelines/index.php/Guidelines:Menus, the other ones are for KDE 3.
Comment 4 Maciej Pilichowski 2008-06-22 10:41:43 UTC 
The HIG I gave link to -- see above. But this one is good too as well. Settings menu has to be in specific order. Akregator menu (settings) is not.
Comment 5 Christophe Marin 2008-07-24 13:31:16 UTC 
There's no HIG violation in the Akregator's settings menu.
Comment 6 Maciej Pilichowski 2008-07-24 14:23:51 UTC 
Christophe, "configure Akr." is burried somewhere in the middle, according to HIG it should be the last. Clear case, how can you say there is no violation? Reopening.
Comment 7 Christophe Marin 2008-07-24 17:25:26 UTC 
Created attachment 26375 [details]
...

Something like this ? fine, that's exactly the akregator's settings menu.

Hint : look in you $KDEHOME/share/apps/akregator and remove the .rc files you
will find...
Comment 8 Christophe Marin 2008-07-24 17:29:57 UTC 
Ah, I see what's your problem. patch coming soon
Comment 9 Teemu Rytilahti 2008-08-19 14:05:06 UTC 
Yeah, the order is wrong and should be fixed, I'm currently working on it and I'm going to commit it when I figure out how to handle duplicates inside Kontact.
Comment 10 Teemu Rytilahti 2008-08-19 19:40:56 UTC 
Partly fixed by my last commit.

SVN commit 849501 by rytilahti:

use KStandardActions to create the settings menu. follow also the same order for menu entries than other KDE applications.

it currently duplicates menu entries when running inside kontact (for settings menu), need to take a look at that later. just wanted to commit if someone has an idea how
this could be fixed.

CCBUGS:164649


 M  +11 -4     actionmanagerimpl.cpp  
 M  +12 -7     akregator_part.rc  
 M  +11 -12    akregator_shell.rc  
 M  +3 -6      mainwindow.cpp
Comment 11 Frank Osterfeld 2008-10-29 01:00:22 UTC 
*** Bug 147895 has been marked as a duplicate of this bug. ***
Comment 12 Pino Toscano 2008-11-01 12:36:53 UTC 
*** Bug 173990 has been marked as a duplicate of this bug. ***
Comment 13 Christophe Marin 2009-03-07 12:46:08 UTC 
*** Bug 127962 has been marked as a duplicate of this bug. ***