Bug 155025 - konqeuror history duplication in go menu
Summary: konqeuror history duplication in go menu
Status: RESOLVED WORKSFORME
Alias: None
Product: konqueror
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-03 15:56 UTC by Dmitriy Taychenachev
Modified: 2008-06-03 11:20 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
patch (3.91 KB, patch)
2008-01-03 16:07 UTC, Dmitriy Taychenachev
Details
almost same patch, with some indentation fixes (4.02 KB, patch)
2008-01-04 05:35 UTC, Dmitriy Taychenachev
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitriy Taychenachev 2008-01-03 15:56:11 UTC
Version:            (using KDE Devel)
Installed from:    Compiled sources
Compiler:          gcc (GCC) 4.2.3 20071123 (prerelease) (Debian 4.2.2-4) 
OS:                Linux

Items in history menu (Go->History) is not cleared properly after first menu creating. Entering in history menu twice or more times will cause invalid history list: there will be items of first history view (they are not working) and correct and working items of current history.
Comment 1 Dmitriy Taychenachev 2008-01-03 16:07:31 UTC
Created attachment 22823 [details]
patch

This patch fixes described bug and this:
1) When building a history action lists, why not to use existing ones? This
patch does.
2) I hope we need only 10 items to show, not 11.
3) Fixes crash (to reproduce - create a history with depth 10 (or more), press
Back three times and try to look in Go->History).
Comment 2 Dmitriy Taychenachev 2008-01-04 05:35:22 UTC
Created attachment 22826 [details]
almost same patch, with some indentation fixes

also cleans icon if item is checked.
Comment 3 Christophe Marin 2008-06-01 17:27:17 UTC
Can't reproduce this bug in trunk (svn rev. 815196)
Comment 4 Christophe Marin 2008-06-03 11:20:28 UTC
Closing this bug.