Bug 149643 - Duplicate songs are no longer allowed in playlist
Summary: Duplicate songs are no longer allowed in playlist
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: general (show other bugs)
Version: 1.4.6
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-09-08 06:05 UTC by Jim Bowlin
Modified: 2007-09-11 01:36 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jim Bowlin 2007-09-08 06:05:11 UTC
Version:           1.4.6 (using KDE KDE 3.5.7)
Installed from:    Gentoo Packages
Compiler:          gcc version 4.1.2 

After upgrading from 1.4.5 to 1.4.6 it seems to be impossible to have
duplicate songs in the playlist.  I can understand having the
Playlist --> Remove Duplicates feature but it seems to be always on
now which seems broken to me.

I expect to be able to add duplicate songs to the playlist if I so
desire.   What's next?  Are we going to filter out duplicate notes?
Comment 1 Seb Ruiz 2007-09-08 06:58:44 UTC
No need for the attitude. First, you could explain what action you were using to add songs to the playlist - drag and drop, from the collection, from a playlist, from an external app etc.
Comment 2 Jim Bowlin 2007-09-08 09:10:00 UTC
I usually add songs to the playlist by right clicking on songs or albums in the collection and then selecting "append to playlist" or by double clicking on a song or album in the collection.  If the entire album was in the playlist then nothing happens.**  If only some of the songs are in the playlist then only the songs that aren't duplicates get added.

I am able to drag-and-drop duplicate songs from the collection to the playlist.  I can even use the right-click menu to add duplicates from my playlists.  But I can't add duplicates from my playlists by double-clicking, only with the right-click menu and drag-and-drop.

So the problem seems to be restricted to just the right-click menu and double clicking in the collection; and double-clicking in my playlists.

I can work around the bug by remembering to always drag-and-drop instead of using the right-click menu or double clicking.

** If I double click on an album or song that has duplicates in the playlist then the status line (?) at the bottom of the amaroK window tells me "X songs were already in the playlist, so they were not added".  This led me to believe that this behavior was considered a feature, not a bug.  The message does not appear when I use the right-click menu or when I double-click on one of my playlists.
Comment 3 Mark Kretschmann 2007-09-10 21:31:10 UTC
I actually agree that this feels more like a bug than a feature (although I think it was meant to be a feature for some reason). IMHO we should revert this.
Comment 4 Seb Ruiz 2007-09-11 01:36:08 UTC
SVN commit 710825 by seb:

Fix incorrect logic: duplicates would always be filtered out when inserting into the playlist regardless of the Unique flag or not.
BUG: 149643


 M  +4 -1      playlist.cpp  


--- branches/stable/extragear/multimedia/amarok/src/playlist.cpp #710824:710825
@@ -508,7 +508,10 @@
         }
     }
 
-    insertMediaInternal( addMe, after, options );
+    if( options & Unique )
+        insertMediaInternal( addMe, after, options );
+    else
+        insertMediaInternal(  list, after, options );
 }
 
 void