Version: 3.5.5 (using KDE 3.5.5, Arch Linux) Compiler: Target: i686-pc-linux-gnu OS: Linux (i686) release 2.6.19-ARCH the "Modify Search Provider" dialogue is too wide, if X is using mergedFB settings and two screens side-by side. (dekstop resolution 2560x1024, two screens with 1280x1024 side by side) most probably, the dialogue width is set as a percentage of the desktop. it should be the percentage of the active screen instead.
Created attachment 19166 [details] illustration of the problem
Confirmed. Here SUSE-10.0/KDE-3.5.5 Width of dialog (on a notebook with 1400x1050 screen) is 100% of screen. Could it be that the dialog is as long because of one of the "Search URIs" being very long, and the dialog adapting to the longest string in the list?
could be - i have just made a guess with the percentage. this way or that, it should have at least a max-width set to screen width, because if the window is wider than a screen, it becomes not usable any more. ... what makes me wonder is also that one cannot make it smaller.
The guilty line is line 46 in kdebase/kcontrol/ebrowsing/ikws/searchproviderdlg.cpp: m_dlg->leQuery->setMinimumWidth(kapp->fontMetrics().maxWidth() * 40); Something like this is needed to make the dialog a sensible width (if you remove the line, the dialog is too narrow), but I don't know the best thing to do.
FWIW, changing '40' to '20' seems alright.
i'm no coder in qt... but can't you use something like screenGeometry public final QRect screenGeometry(QWidget widget) Returns the geometry of the screen which contains widget. instead of this fontMetrics? so that it is really limited with the screen-size. otherwise, it would be possible to make m_dlg wider than a screen if simply dependend on fontMetrics. if it is wider than a screen it becomes unusable, so we do not want that in any case, right?
sorry.. it is too late, i messed up what i wanted to write. what i meant is: in addition to setMinimumWidth(depending on the contents of the box) there should be also a SetMaximumWidth(depending on the screen size)
It is almost fixed in trunk r813735, should be gone in final 4.1, review it again then.
This issue is fixed in Kubuntu 10.10 KDE 4.6.2 and master/branch 4.6 compiled from sources.
This ussue was fixed http://websvn.kde.org/?view=revision&revision=931086 by shaforo Date: Tue Feb 24 19:00:20 2009 UTC (2 years, 3 months ago) Log Message: -modernize kuriikwsfiltereng.cpp with new qstring and co api. all tests are passing. -compact searchproviderdlg