Bug 132549 - [PATCH] Crash in the "do you want to store the password" diallog when submiting a form and you already left that page
Summary: [PATCH] Crash in the "do you want to store the password" diallog when submiti...
Status: RESOLVED WORKSFORME
Alias: None
Product: konqueror
Classification: Applications
Component: khtml forms (show other bugs)
Version: 3.5
Platform: unspecified Linux
: NOR crash
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-08-17 14:14 UTC by Albert Astals Cid
Modified: 2008-04-21 10:18 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Albert Astals Cid 2006-08-17 14:14:38 UTC
Version:           3.5.4 (using KDE 3.5.4, compiled sources)
Compiler:          Target: x86_64-linux-gnu
OS:                Linux (x86_64) release 2.6.15-26-amd64-k8

How to reproduce:

1 - Go to a page that has password and you don't have in your kwallet, i tested with google analytics
2 - fill in username and password
3 - click a link that leaves the page and then before letting the page change press the "sign in" button
4 - You get the dialog asking if you want to store the page while beign in the "new page" already
5 - Click do not store
6 - Crash

Here's the backtrace

#0  0x00002aaab0c94dba in KHTMLPart::submitForm (this=0x0, action=0x2aaab0ee1856 "post", url=@0x7fffff83cbf0, formData=@0x7fffff83ca50, _target=@0x7fffff83cbe0,
    contentType=@0x7fffff83cbc0, boundary=@0xb76b80) at /home/kde35/kdelibs/khtml/khtml_part.cpp:4719
#1  0x00002aaab0d2ac5d in DOM::HTMLFormElementImpl::submit (this=0xb76a80) at /home/kde35/kdelibs/khtml/html/html_formimpl.cpp:650
#2  0x00002aaab0d2af01 in DOM::HTMLFormElementImpl::prepareSubmit (this=0xb76a80) at /home/kde35/kdelibs/khtml/html/html_formimpl.cpp:553
#3  0x00002aaab0d2af7b in DOM::HTMLInputElementImpl::activate (this=0x89dde0) at /home/kde35/kdelibs/khtml/html/html_formimpl.cpp:1819
#4  0x00002aaab0d2b3cb in DOM::HTMLInputElementImpl::defaultEventHandler (this=0x89dde0, evt=0xabe220) at /home/kde35/kdelibs/khtml/html/html_formimpl.cpp:1802
#5  0x00002aaab0cd9afd in DOM::NodeImpl::dispatchGenericEvent (this=0x89dde0, evt=0xabe220) at /home/kde35/kdelibs/khtml/xml/dom_nodeimpl.cpp:404
#6  0x00002aaab0cd9f19 in DOM::NodeImpl::dispatchEvent (this=0x89dde0, evt=0xabe220, exceptioncode=@0x7fffff83ce70, tempEvent=true)
    at /home/kde35/kdelibs/khtml/xml/dom_nodeimpl.cpp:348
#7  0x00002aaab0cdb34c in DOM::NodeImpl::dispatchUIEvent (this=0x89dde0, _id=3, detail=1) at /home/kde35/kdelibs/khtml/xml/dom_nodeimpl.cpp:556
#8  0x00002aaab0cd9bcb in DOM::NodeImpl::dispatchGenericEvent (this=0x89dde0, evt=0xaa1160) at /home/kde35/kdelibs/khtml/xml/dom_nodeimpl.cpp:408
#9  0x00002aaab0cd9f19 in DOM::NodeImpl::dispatchEvent (this=0x89dde0, evt=0xaa1160, exceptioncode=@0x7fffff83d0cc, tempEvent=true)
    at /home/kde35/kdelibs/khtml/xml/dom_nodeimpl.cpp:348
#10 0x00002aaab0c536f0 in KHTMLView::dispatchMouseEvent (this=0xa7dab0, eventId=4, targetNode=0x89dde0, targetNodeNonShared=0x89dde0, cancelable=true, detail=1,
    _mouse=0x7fffff83d210, setUnder=true, mouseEventType=1) at /home/kde35/kdelibs/khtml/khtmlview.cpp:3193
#11 0x00002aaab0c59b83 in KHTMLView::viewportMouseReleaseEvent (this=0xa7dab0, _mouse=0x7fffff83d360) at /home/kde35/kdelibs/khtml/khtmlview.cpp:1287
#12 0x00002aaab0c5bb0e in KHTMLView::eventFilter (this=0xa7dab0, o=0xb451d0, e=0x7fffff83da90) at /home/kde35/kdelibs/khtml/khtmlview.cpp:1956
#13 0x00002aaaad00482d in QObject::activate_filters () from /usr/lib/libqt-mt.so.3
#14 0x00002aaaad0048a6 in QObject::event () from /usr/lib/libqt-mt.so.3
#15 0x00002aaaad03f219 in QWidget::event () from /usr/lib/libqt-mt.so.3
#16 0x00002aaaacfa0c34 in QApplication::internalNotify () from /usr/lib/libqt-mt.so.3
#17 0x00002aaaacfa127d in QApplication::notify () from /usr/lib/libqt-mt.so.3
#18 0x00002aaaac118905 in KApplication::notify (this=0x7fffff83e3b0, receiver=0xb451d0, event=0x7fffff83da90) at /home/kde35/kdelibs/kdecore/kapplication.cpp:550
#19 0x00002aaaacf323d8 in QApplication::sendSpontaneousEvent () from /usr/lib/libqt-mt.so.3
#20 0x00002aaaacf2dba8 in QETWidget::translateMouseEvent () from /usr/lib/libqt-mt.so.3
#21 0x00002aaaacf2bfcb in QApplication::x11ProcessEvent () from /usr/lib/libqt-mt.so.3
#22 0x00002aaaacf44e7b in QEventLoop::processEvents () from /usr/lib/libqt-mt.so.3
#23 0x00002aaaacfb8aca in QEventLoop::enterLoop () from /usr/lib/libqt-mt.so.3
#24 0x00002aaaacfb89d3 in QEventLoop::exec () from /usr/lib/libqt-mt.so.3
#25 0x00002aaaacf9f8a0 in QApplication::exec () from /usr/lib/libqt-mt.so.3
#26 0x00002aaaaac4f177 in kdemain (argc=1, argv=0x7fffff83ee08) at /home/kde35/kdebase/konqueror/konq_main.cc:206
#27 0x0000000000400783 in main (argc=1, argv=0x7fffff83ee08) at ./konqueror/kdeinit_konqueror.cpp:2


I know i'm evil, sorry ;-)
Comment 1 Albert Astals Cid 2006-08-17 14:23:01 UTC
Arg, typo, point 4 should be:
4 - You get the dialog asking if you want to store the password while beign in the "new page" already 
Comment 2 Tommi Tervo 2006-08-18 09:46:26 UTC
Trying to fix categories again.

http://impul.se/~kling/kde/bug-132549.diff
Comment 3 Albert Astals Cid 2006-08-18 13:24:52 UTC
the patch removes the crash although the final behaviour is "strange", because if you see the password dialog that seems to imply the "taken into account click" was the password one, but you end up in the first link you clicked, don't know if i explain myself.

But anyway i'd commit the patch and open a separate bug for the behaviour thingy.
Comment 4 Michael Zanetti 2008-04-20 21:32:36 UTC
fixed in r799166
Comment 5 Michael Zanetti 2008-04-20 21:53:26 UTC
fixed also in 3.5.9. Can be closed.
Comment 6 James Spahlinger 2008-04-21 10:18:55 UTC
Confirmed the fix, works for me with 3.5.9