Bug 130501 - Tagging New Songs: "Erasure" of Metadata in Multiple-Tag-Edit Mode
Summary: Tagging New Songs: "Erasure" of Metadata in Multiple-Tag-Edit Mode
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: general (show other bugs)
Version: 1.4.0
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
: 124291 127818 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-07-09 07:11 UTC by Mats Ahlgren
Modified: 2008-06-16 16:18 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mats Ahlgren 2006-07-09 07:11:45 UTC
Version:           1.4.0 (using KDE 3.5.2, Kubuntu Package 4:3.5.2-0ubuntu18 dapper)
Compiler:          Target: i486-linux-gnu
OS:                Linux (i686) release 2.6.15-25-686

=== Problem:
When changing metadata of multiple new songs, AmaroK deletes all the previous metadata the songs were intialized with.

=== Specifics:
When new songs without metadata are added to one's collection, AmaroK initializes the song title and artist (and maybe other tags) by looking at the filename. When any such song is part of a metadata batch-edit for the first time ever, all such initialized info is destroyed except for the new info the user just added.

=== Replication:
* step 1) Import two new songs into your library.

e.g.
song1.filename = "01 - First Song"; song2.filename = ...
AmaroK will then guess (perhaps incorrectly, it doesn't matter) the following metadata:
song1.metadata = {title = "First Song", artist = "01"}; song2.metadata = ...

* step 2) Select both songs, right-click, and activate the metadata editor in batch mode. Click, then un-click, the "Per Track" button.

What you should see: All song metadata is now blank! Proceed to click the "Cancel" button so we can further experiment.

* step 3) Enter the batch-editor again. Now, try this: change the artist (or any other tags you want) to any desired value, and save the changes.

What you should see: All the initialized metadata of the songs have been deleted, and only the metadata you added remains!

e.g.
when changing artist from "01" to "Celine Dion"
song1.new_metadata = {title = "", artist = "Celine Dion"}

Expected behavior:
song1.new_metadata = {title = "First Song", Artist = "Celine Dion"}

=== Other Notes
A strange interaction may prevent this bug from showing up in single-edit mode: old metadata cannot "disappear" because it must remain in the text fields, and thus following the above replication instructions in single-edit mode will not yield any results.

I believe this bug was alluded to in bug 128881, but was never caught because the culprit in bug 128881 was actually a different problem.

=== Further Suggestions
In light of bugs like this and severe bugs like bug 130045, I suggest someone go through the metadata batch-edit code carefully, and maybe implement some sort of backup or "undo" functionality for tag edits, which are current irreversible.

Hope this helps.
Comment 1 Alexandre Oliveira 2006-07-25 18:30:24 UTC
*** Bug 124291 has been marked as a duplicate of this bug. ***
Comment 2 Alexandre Oliveira 2006-07-25 18:30:26 UTC
*** Bug 127818 has been marked as a duplicate of this bug. ***
Comment 3 Edward Hades 2008-06-15 11:46:26 UTC
This bug is fixed as of Amarok 1.4.9.1 (and also in Amarok 2).
Comment 4 Edward Hades 2008-06-16 16:18:28 UTC
Thank you for your report, this bug has been fixed in recent amarok versions.

Please come back, if you experience any more bugs in amarok.